Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NotebookEdit in WorkspaceEdit #1336

Open
karthiknadig opened this issue Oct 6, 2023 · 4 comments
Open

Add support for NotebookEdit in WorkspaceEdit #1336

karthiknadig opened this issue Oct 6, 2023 · 4 comments
Labels
feature-request Request for new features or functionality
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented Oct 6, 2023

Currently there is no way to provide diffs at the notebook level. We currently receive notebook changes in the form of notebook synchronization events.

The Notebook features that are available from TS APIs like WorkspaceEdit.set is currently not exposed to Language Servers. Having this will allow language servers to perform notebook level "formatting" (restructuring), refactoring, insert/delete/re-order cells.

Adding NotebookEdit support can generally allow updating notebooks via formatting, code action, or any request.

Notes:

ref: microsoft/vscode#204544

@karthiknadig karthiknadig changed the title Add notebook/format request type Add notebookDocument/formatting request type Oct 6, 2023
@dbaeumer
Copy link
Member

dbaeumer commented Oct 9, 2023

How is this currently triggered via the VS Code API_

@dbaeumer dbaeumer added info-needed Issue requires more information from poster feature-request Request for new features or functionality labels Oct 9, 2023
@dbaeumer dbaeumer added this to the Backlog milestone Oct 9, 2023
@karthiknadig karthiknadig changed the title Add notebookDocument/formatting request type [WIP] Add notebookDocument/formatting request type Oct 9, 2023
@karthiknadig
Copy link
Member Author

This currently isn't, I created this issue as a tracking item for getting details down for the protocol side. I will create and attach this to the core issue to trigger this from the VS Code side.

@dbaeumer dbaeumer removed the info-needed Issue requires more information from poster label Oct 10, 2023
@dbaeumer
Copy link
Member

Ok. Thanks!

@karthiknadig karthiknadig self-assigned this Oct 31, 2023
@karthiknadig karthiknadig changed the title [WIP] Add notebookDocument/formatting request type Add notebookDocument/formatting request type Feb 2, 2024
@karthiknadig
Copy link
Member Author

karthiknadig commented Feb 2, 2024

@dbaeumer : @rebornix and I are looking into this issue for this milestone. LSP work items might show up on this for the next milestone. We are working on figuring out the Core workspace edit API which actually supports notebooks edits, but there are some minor differences in how we handle addition and removal in LSP vs how it is done in the current Notebook API. Once we have that figured out we will create specific items needed from LSP for this task.

@karthiknadig karthiknadig removed their assignment Feb 20, 2024
@karthiknadig karthiknadig changed the title Add notebookDocument/formatting request type Add support for NotebookEdit in WorkspaceEdit Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants