Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the inlineCompletion example #879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tardyp
Copy link

@tardyp tardyp commented Jun 21, 2023

Now that the extension is GA, the code sample does not need the enableAPIProposal config.
the API has been simplified a bit since the proposal, so the code has been simplified as well

Fixes #867

Fixes microsoft/vscode#150732

@tardyp
Copy link
Author

tardyp commented Jun 21, 2023

@microsoft-github-policy-service agree

@tardyp
Copy link
Author

tardyp commented Jun 21, 2023

@hediet

Now that the extension is GA, the code sample does not need the proposed API
the API has been simplified a bit since the proposal, so the code has been simplified as well
Copy link

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks!

Copy link

@yaokangyou yaokangyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

121212

Copy link

@yaokangyou yaokangyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

121212

@rcjsuen
Copy link

rcjsuen commented Sep 4, 2024

@tardyp Thank you so much for this workaround. The sample is working for me now!

@hediet Any chance we can get this reviewed and merged?

@wangzelin007
Copy link
Member

Works for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inline-completions example is not work Problem running inlineCompletions Sample
6 participants