Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color completion only displays color squares for hex variables #314

Open
GauravB159 opened this issue Nov 13, 2022 · 2 comments
Open

Color completion only displays color squares for hex variables #314

GauravB159 opened this issue Nov 13, 2022 · 2 comments

Comments

@GauravB159
Copy link
Contributor

GauravB159 commented Nov 13, 2022

Based on issue microsoft/vscode#166197

image

File: cssCompletion.ts

This function only tests for built-in colors and hex values. Adding another part to it that checks for color functions fixes the two color functions.

Making this change fixes $rgb and $rgba.

@allan2
Copy link

allan2 commented Nov 13, 2022

@GauravB159 do you know if your PR also helps with vscode #166201?

@GauravB159
Copy link
Contributor Author

@allan2 That's actually a separate issue. I've looked into that as well, and I'm mostly done with it. But there are a few tests failing. I might push a draft PR in a bit anyways because I'm not sure if those tests are based on correct behavior or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants