From edb10e6b401a041497b8cea39eb8cc8fab7d6992 Mon Sep 17 00:00:00 2001 From: satoshionoda Date: Tue, 19 Nov 2024 13:27:05 +0900 Subject: [PATCH 1/2] Update README.md the example was not working as the property name `model` is a reserved keyword. --- packages/json-schema/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/json-schema/README.md b/packages/json-schema/README.md index 592b9c6735..f0a0bb672e 100644 --- a/packages/json-schema/README.md +++ b/packages/json-schema/README.md @@ -21,8 +21,8 @@ using TypeSpec.JsonSchema; namespace Example; model Car { - make: string; - model: string; + maker: string; + modelName: string; } ``` From 4665c41415f592cdf56f6c966bd03ed769961b7a Mon Sep 17 00:00:00 2001 From: Alitzel Mendez Bustillo Date: Tue, 17 Dec 2024 10:25:53 -0800 Subject: [PATCH 2/2] feedback --- packages/json-schema/.tspd/docs/usage.md | 2 +- packages/json-schema/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/json-schema/.tspd/docs/usage.md b/packages/json-schema/.tspd/docs/usage.md index a7f745db43..4ab5eb752e 100644 --- a/packages/json-schema/.tspd/docs/usage.md +++ b/packages/json-schema/.tspd/docs/usage.md @@ -10,6 +10,6 @@ namespace Example; model Car { make: string; - model: string; + modelName: string; } ``` diff --git a/packages/json-schema/README.md b/packages/json-schema/README.md index f0a0bb672e..0e7cb16c49 100644 --- a/packages/json-schema/README.md +++ b/packages/json-schema/README.md @@ -21,7 +21,7 @@ using TypeSpec.JsonSchema; namespace Example; model Car { - maker: string; + make: string; modelName: string; } ```