From 3f2d10a644e5d06f72686dc3c4d966815bb761c9 Mon Sep 17 00:00:00 2001 From: Pan Shao <97225342+pshao25@users.noreply.github.com> Date: Thu, 19 Dec 2024 11:40:59 +0800 Subject: [PATCH] Fix tsp-spector coverage breaking change (#5409) new tsp-spector now needs a required parameter to publish coverage report. Without this parameter, ci will fail with error ![image](https://github.com/user-attachments/assets/e6a6abb7-fd0c-4ed3-a998-0c4058e12828) Checked it works in this ci: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4421855&view=results Co-authored-by: Pan Shao --- eng/emitters/pipelines/templates/steps/test-step.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/emitters/pipelines/templates/steps/test-step.yml b/eng/emitters/pipelines/templates/steps/test-step.yml index db44e14b1e..04c7943ccc 100644 --- a/eng/emitters/pipelines/templates/steps/test-step.yml +++ b/eng/emitters/pipelines/templates/steps/test-step.yml @@ -74,5 +74,5 @@ steps: azureSubscription: "TypeSpec Storage" scriptType: "bash" scriptLocation: "inlineScript" - inlineScript: npx tsp-spector upload-coverage --coverageFile ./generator/artifacts/coverage/tsp-spector-coverage-${{ parameters.LanguageShortName }}-standard.json --generatorName ${{ coalesce(parameters.CadlRanchName, parameters.LanguageShortName) }} --storageAccountName typespec --generatorVersion $(node -p -e "require('./package.json').version") --generatorMode standard + inlineScript: npx tsp-spector upload-coverage --coverageFile ./generator/artifacts/coverage/tsp-spector-coverage-${{ parameters.LanguageShortName }}-standard.json --generatorName ${{ coalesce(parameters.CadlRanchName, parameters.LanguageShortName) }} --storageAccountName typespec --containerName coverages --generatorVersion $(node -p -e "require('./package.json').version") --generatorMode standard workingDirectory: $(selfRepositoryPath)${{ parameters.PackagePath }}