[C#] feat: Allow passing custom credentials factory to CloudAdapter #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepro
requested review from
aacebo,
corinagum,
lilyydu and
singhk97
as code owners
stepro
changed the title
aacebo
approved these changes
Nov 11, 2024
|
@aacebo what else is needed to merge this PR? I'm not authorized to merge. Thanks! |
|
@singhk97 can you take a look and merge this if you approve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
closes: #2130
Details
Added an additional constructor to CloudAdapter that allows passing a custom credentials factory to CloudAdapter. This enables using an alternative credentials factory, like FederatedServiceClientCredentialsFactory, instead of it being hardcoded to the ConfigurationServiceClientCredentialFactory.
Attestation Checklist