From eb604629845dd7471c261bd741b941470343fa52 Mon Sep 17 00:00:00 2001
From: pp-akursar <123969479+pp-akursar@users.noreply.github.com>
Date: Fri, 22 Sep 2023 17:43:48 -0400
Subject: [PATCH] Upgrade to Spark 3.4.0 (#235)

Test pass done on spark 3.4.0
---
 .github/workflows/scala.yml | 2 +-
 README.md                   | 1 +
 pom.xml                     | 6 +++---
 test/scala_test/pom.xml     | 4 ++--
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/scala.yml b/.github/workflows/scala.yml
index ebeca40..de443cb 100644
--- a/.github/workflows/scala.yml
+++ b/.github/workflows/scala.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest]
-        profile: ['spark33']
+        profile: ['spark34']
     timeout-minutes: 15
 
     steps:
diff --git a/README.md b/README.md
index d5496f3..762b7e3 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,7 @@ There are three version sets of the connector available through Maven, a 2.4.x,
 | Spark 3.0.x compatible connector | `com.microsoft.azure:spark-mssql-connector_2.12:1.1.0` | 2.12          |
 | Spark 3.1.x compatible connector | `com.microsoft.azure:spark-mssql-connector_2.12:1.2.0` | 2.12          |
 | Spark 3.3.x compatible connector | `com.microsoft.azure:spark-mssql-connector_2.12:1.3.0` | 2.12          |
+| Spark 3.4.x compatible connector | `com.microsoft.azure:spark-mssql-connector_2.12:1.4.0` | 2.12          |
 
 ## Current Releases
 
diff --git a/pom.xml b/pom.xml
index cfc55de..780bd73 100644
--- a/pom.xml
+++ b/pom.xml
@@ -4,7 +4,7 @@
     <groupId>com.microsoft.azure</groupId>
     <artifactId>spark-mssql-connector</artifactId>
     <packaging>jar</packaging>
-    <version>1.3.0</version>
+    <version>1.4.0</version>
     <name>${project.groupId}:${project.artifactId}</name>
     <description>The Apache Spark Connector for SQL Server and Azure SQL is a high-performance connector that enables you to use transactional data in big data analytics and persists results for ad-hoc queries or reporting.</description>
     <url>https://github.com/microsoft/sql-spark-connector</url>
@@ -201,14 +201,14 @@
     </build>
     <profiles>
         <profile>
-            <id>spark33</id>
+            <id>spark34</id>
             <activation>
                 <activeByDefault>true</activeByDefault>
             </activation>
             <properties>
                 <scala.binary.version>2.12</scala.binary.version>
                 <scala.version>2.12.11</scala.version>
-                <spark.version>3.3.0</spark.version>
+                <spark.version>3.4.0</spark.version>
             </properties>
             <dependencies>
                 <dependency>
diff --git a/test/scala_test/pom.xml b/test/scala_test/pom.xml
index 53743cc..5382818 100644
--- a/test/scala_test/pom.xml
+++ b/test/scala_test/pom.xml
@@ -123,14 +123,14 @@
     </build>
     <profiles>
         <profile>
-            <id>spark33</id>
+            <id>spark34</id>
             <activation>
                 <activeByDefault>true</activeByDefault>
             </activation>
             <properties>
                 <scala.binary.version>2.12</scala.binary.version>
                 <scala.version>2.12.11</scala.version>
-                <spark.version>3.3.0</spark.version>
+                <spark.version>3.4.0</spark.version>
             </properties>
         </profile>
     </profiles>