Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Exception Serializer #260

Open
8ggmaker opened this issue Dec 10, 2020 · 3 comments
Open

Custom Exception Serializer #260

8ggmaker opened this issue Dec 10, 2020 · 3 comments

Comments

@8ggmaker
Copy link
Member

Is it possible to custom exception serializer for exceptions of remoting call? Message's serializer can be customized by implementing IServiceRemotingMessageSerializationProvider, but it seems exception's serializer is hardcode in RemoteException class:

private static readonly DataContractSerializer serviceExceptionDataSerializer = new DataContractSerializer(typeof(ServiceExceptionData));

and can not be customized. Is there anyway to achieve this? Thanks

@ameyanator
Copy link
Contributor

Hi @zsybupt, as of today it is not possible to customize the exception serializer

@8ggmaker
Copy link
Member Author

@ameyanator Thanks for replying, I have another question about why ServiceFabric wraps remote server exception into an AggregateException, and the client has to check the inner exception to check what is happened

@ameyanator
Copy link
Contributor

Hi @zsybupt, I see that.

I will try and discuss this with the broader team and will let you know/get back to you if there might be some design or specific consideration as to why it is like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants