From 4f9af4bdc08d8d39bb3fc88981ecfff8d0cac735 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 23 Oct 2024 10:35:44 +0200 Subject: [PATCH 1/3] fixed issue 225 --- src/sempy_labs/_model_bpa_rules.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sempy_labs/_model_bpa_rules.py b/src/sempy_labs/_model_bpa_rules.py index 64119bef..7d515059 100644 --- a/src/sempy_labs/_model_bpa_rules.py +++ b/src/sempy_labs/_model_bpa_rules.py @@ -646,11 +646,11 @@ def model_bpa_rules( ), ( "Maintenance", - "Column", + ["Column", "Measure", "Table"], "Info", "Visible objects with no description", lambda obj, tom: obj.IsHidden is False and len(obj.Description) == 0, - "Calculation groups have no function unless they have calculation items.", + "Add descriptions to objects. These descriptions are shown on hover within the Field List in Power BI Desktop. Additionally, you can leverage these descriptions to create an automated data dictionary.", ), ( "Formatting", From 6c0b1ab16d36416a9a5e26f0545ee3d5ae47fdc7 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 23 Oct 2024 11:37:48 +0200 Subject: [PATCH 2/3] fixed issue 226 --- src/sempy_labs/admin/_basic_functions.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/sempy_labs/admin/_basic_functions.py b/src/sempy_labs/admin/_basic_functions.py index af11168b..678906a5 100644 --- a/src/sempy_labs/admin/_basic_functions.py +++ b/src/sempy_labs/admin/_basic_functions.py @@ -972,12 +972,14 @@ def list_activity_events( conditions = [] if activity_filter is not None: - conditions.append(f"Activity{space}eq{space}{tic}{activity_filter}{tic}") + activity_filter_condition = urllib.parse.quote(activity_filter) + conditions.append(f"Activity{space}eq{space}{tic}{activity_filter_condition}{tic}") if user_id_filter is not None: - conditions.append(f"UserId{space}eq{space}{tic}{user_id_filter}{tic}") + user_id_filter_condition = urllib.parse.quote(user_id_filter) + conditions.append(f"UserId{space}eq{space}{tic}{user_id_filter_condition}{tic}") filter_value = ( - f"&filter={f'{space}and{space}'.join(conditions)}" if conditions else "" + f"&$filter={f'{space}and{space}'.join(conditions)}" if conditions else "" ) full_url = f"{base_url}?startDateTime={tic}{start_time}{tic}&endDateTime={tic}{end_time}{tic}{filter_value}" From 7d5f7ab89bf0993c473329f04d532b1c4975169e Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 23 Oct 2024 11:39:35 +0200 Subject: [PATCH 3/3] undid change. it's in the other PR --- src/sempy_labs/admin/_basic_functions.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/sempy_labs/admin/_basic_functions.py b/src/sempy_labs/admin/_basic_functions.py index 678906a5..af11168b 100644 --- a/src/sempy_labs/admin/_basic_functions.py +++ b/src/sempy_labs/admin/_basic_functions.py @@ -972,14 +972,12 @@ def list_activity_events( conditions = [] if activity_filter is not None: - activity_filter_condition = urllib.parse.quote(activity_filter) - conditions.append(f"Activity{space}eq{space}{tic}{activity_filter_condition}{tic}") + conditions.append(f"Activity{space}eq{space}{tic}{activity_filter}{tic}") if user_id_filter is not None: - user_id_filter_condition = urllib.parse.quote(user_id_filter) - conditions.append(f"UserId{space}eq{space}{tic}{user_id_filter_condition}{tic}") + conditions.append(f"UserId{space}eq{space}{tic}{user_id_filter}{tic}") filter_value = ( - f"&$filter={f'{space}and{space}'.join(conditions)}" if conditions else "" + f"&filter={f'{space}and{space}'.join(conditions)}" if conditions else "" ) full_url = f"{base_url}?startDateTime={tic}{start_time}{tic}&endDateTime={tic}{end_time}{tic}{filter_value}"