Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepush download sucessfully but the bundle doesn't apply on ios only #2687

Closed
phantrungviet98 opened this issue Apr 2, 2024 · 6 comments
Closed

Comments

@phantrungviet98
Copy link

Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):

Steps to Reproduce

  1. appcenter codepush release-react -a xxx -t 15..
  2. app received codepush and installed successfully
  3. codePush.getUpdateMetadata() returns correct bundle version, but actually the bundle doesn't apply

Expected Behavior

  • the bundle apply correctly

Actual Behavior

codePush.getUpdateMetadata() return expected installed bundle but it doesn't apply

  STACK TRACE AND/OR SCREENSHOTS

Reproducible Demo

Environment

  • react-native-code-push version: 8.0.2
  • react-native version: 0.72.10
  • iOS/Android/Windows version: 16
  • Does this reproduce on a debug build or release build? Release build
  • Does this reproduce on a simulator, or only on a physical device? both

(The more info the faster we will be able to address it!)

@phantrungviet98
Copy link
Author

i just found that when i download the bundle using staging key it works, but production key it doesn't

@djindal61
Copy link

I am also facing the same error.

@phantrungviet98
Copy link
Author

i tried to set Mandatory for the bundle, it works after the app reload automatically but after reopen the app next time, the bundle is gone.
i guess it is not saved correctly ?

@RuFang-21
Copy link

anyone have solution on this :(

@phantrungviet98
Copy link
Author

@djindal61 @RuFang-21

from my side just because we forgot to return [CodePush bundleURL];

full code there
`- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge

{
#if DEBUG
return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
#else
return [CodePush bundleURL];
#endif
}`

@amanthegreatone
Copy link

pls check this i had this issue which was solved. #2529 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants