Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] __enter__/__exit__ on Browser #2254

Open
jamesbraza opened this issue Jan 22, 2024 · 1 comment
Open

[Feature] __enter__/__exit__ on Browser #2254

jamesbraza opened this issue Jan 22, 2024 · 1 comment

Comments

@jamesbraza
Copy link

I have python-playwright with version 1.41.0, and the below code:

from playwright.sync_api import sync_playwright


with sync_playwright() as p:
    browser = p.chromium.launch()
    ...  # Use browser
    browser.close()

Ideally, one can use a context manager to automate the close() call:

from playwright.sync_api import sync_playwright


with sync_playwright() as p, p.chromium.launch() as browser:
    ...  # Use browser

Thank you for your consideration

@jamesbraza
Copy link
Author

One can get pretty close with contextlib.closing:

import contextlib

from playwright.sync_api import sync_playwright


with sync_playwright() as p, contextlib.closing(p.chromium.launch()) as browser:
    ...  # Use browser

However, it would be nice if this was upstreamed to Browser itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants