Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: async support #201

Closed
jamesbraza opened this issue Jan 25, 2024 · 4 comments
Closed

Request: async support #201

jamesbraza opened this issue Jan 25, 2024 · 4 comments

Comments

@jamesbraza
Copy link

From https://github.com/microsoft/playwright-pytest/blob/v0.4.3/pytest_playwright/pytest_playwright.py#L23-L31, it's clear only synchronous usage is supported here (there are no async_api imports).

Thus, async workflows are not well supported by playwright-pytest. This request is to support asynchronous usage.


Workaround

https://github.com/m9810223/playwright-async-pytest exists, but it's currently pinned to an older version of pytest-playwright: https://github.com/m9810223/playwright-async-pytest/blob/v0.3.0/pyproject.toml#L4

@jamesbraza
Copy link
Author

Actually, this is a duplicate of #74

@mxschmitt
Copy link
Member

Note: I was working on it a while ago but struggled implementing the requirements we had: #184 (comment)

@jamesbraza
Copy link
Author

jamesbraza commented Jan 25, 2024

I added some PR comments, feel free to bounce ideas off me if that helps

@m9810223
Copy link
Contributor

I just loosen the version of pytest-playwright in https://github.com/m9810223/playwright-async-pytest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants