[Bug] autocompletion does not work inside strings

[fdrag]

Reproducible in vscode.dev or in VS Code Desktop?

• Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

• Not reproducible in the monaco editor playground

Monaco Editor Playground Code

monaco.editor.create(document.getElementById('container'), {
	value: "function hello() {\n\talert('Hello world!');\n}",
	language: 'typescript'
});

Actual Behavior

help

Expected Behavior

show autocompletion

Additional Context

if not bug then how to implement string completion? (sorry bad english )

[rcjsuen]

@fdrag Seems fine to me. 🤔

[fdrag]

@fdrag Seems fine to me. 🤔

xBeOt1Z9GW.mp4

[fdrag]

it still not working for me, how to implement string autocompletion myself?

i want to copy this

[rcjsuen]

it still not working for me, how to implement string autocompletion myself?

If you invoke Intellisense explicitly with Control+Space (or Cmd+Space on macOS) it works.

i want to copy this

What is this from?

[fdrag]

it is from visual studio code, im trying to making my own monaco editor for testing purposes but im not knowing how to implement those

how to automatic invoke intellisense when in qoutes?

[rcjsuen]

monaco-editor/src/typescript/languageFeatures.ts

Lines 435 to 438 in a385674

	export class SuggestAdapter extends Adapter implements languages.CompletionItemProvider {
	public get triggerCharacters(): string[] {
	return ['.'];
	}

1. At a surface level, the obvious issue is that the trigger characters in Visual Studio Code are not the same as Monaco's (per above). We can see Monaco does not invoke Intellisense as aggressively as VS Code.

monaco-editor/website/typedoc/monaco.d.ts

Lines 3056 to 3060 in a385674

	/**
	* Enable quick suggestions (shadow suggestions)
	* Defaults to true.
	*/
	quickSuggestions?: boolean | IQuickSuggestionsOptions;

2. Another issue is that quickSuggestions seems to be false when it supposedly defaults to being true. Turning it on explicitly seems to fix your problem. Please try the code below, @fdrag.

const content = `interface env {
	a: "abc" | "def";
}
let env: env = {
	a: ""
}`;
monaco.editor.create(document.getElementById('container'), {
    value: content,
    language: 'typescript',
    quickSuggestions: true
});

[rcjsuen]

const defaults: ValidQuickSuggestionsOptions = {
    other: true,
    comments: false,
    strings: false
};

I think this is the issue. Quick suggestions are enabled by default...they're just not enabled by default if the text caret is inside a comment or a string. The comment should be updated to reflect this in my opinion.

[fdrag]

ValidQuickSuggestionsOptions 

Thank you for your explanation. :D