Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify automl threshold params and add gpu optimizations in object detection ml-wrappers #144

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Aug 15, 2023

modify automl threshold params and add gpu optimizations in object detection ml-wrappers

1.) fix _get_device to be able to handle colons with device number
2.) add transforms to PytorchDRiseWrapper for AutoML support via extracting underlying model as an optimization for running AutoML models on GPU
3.) add threshold params for iou_thresh and score_thresh to predict method and also allow them to be specified on constructor
4.) rename score_thresh and iou_thresh to full name score_threshold and iou_threshold, since we have many cases where these seem to be inconsistent in the codebase - note it looks like these are not used elsewhere in our codebases so it should not affect other projects, but it is a breaking change in case other external users are calling these APIs directly
5.) add tests for the new changes

@imatiach-msft imatiach-msft force-pushed the ilmat/threshold-params branch 3 times, most recently from eb43f57 to 07674c7 Compare August 15, 2023 15:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #144 (39cb5f8) into main (8ecf1c4) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head 39cb5f8 differs from pull request most recent head 4fa1bf2. Consider uploading reports for the commit 4fa1bf2 to get more accurate results

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   75.06%   75.24%   +0.17%     
==========================================
  Files          27       27              
  Lines        1793     1806      +13     
==========================================
+ Hits         1346     1359      +13     
  Misses        447      447              
Flag Coverage Δ
unittests 75.24% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/ml_wrappers/model/image_model_wrapper.py 96.00% <100.00%> (+0.19%) ⬆️

@imatiach-msft imatiach-msft force-pushed the ilmat/threshold-params branch 2 times, most recently from 5c33c02 to 39cb5f8 Compare August 15, 2023 17:33
@imatiach-msft imatiach-msft merged commit 2ed6286 into main Aug 15, 2023
26 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/threshold-params branch August 15, 2023 18:31
This was referenced Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants