Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to pass the HostNameInCertificate parameter for strict encryption connections #504

Open
shueybubbles opened this issue Jan 31, 2024 · 2 comments
Assignees
Labels

Comments

@shueybubbles
Copy link
Collaborator

For legacy mode we have a few options:

  1. Add a new flag for HNIC.
  2. Make HNIC an optional parameter to -C, such that -C X means "trust the cert only if its subject is X"
  3. Expand the optional arguments to -N so that each encryption type can have parameters of its own.
    Something like this:
    -N strict:HNIC=myhost.com

Option 1 is a pain because we are running out of flags. Option 2 solves for this specific problem.

Option 3 is intriguing because it opens the door for supporting more encryption parameters in the future without needing to add new flags. It also simplifies detection of invalid flag combinations.

@dlevy-msft

@stuartpa how does the modern mode allow the user to set encryption values for connections to non-container instances?

@apoorvdeshmukh
Copy link
Contributor

Option 3 looks good. due to the flexibility it offers to add future parameters. I guess we could extend it to other flags as well if needed.

@stuartpa
Copy link
Collaborator

stuartpa commented Feb 1, 2024

@stuartpa how does the modern mode allow the user to set encryption values for connections to non-container instances?

It doesn't today. Users seem to be using the sqlconfig file for connections to containers on the local machine at the moment

@shueybubbles shueybubbles self-assigned this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants