Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Selected tab is not very visible under high contrast and dessert mode #33516

Open
2 tasks done
phyyuel opened this issue Dec 24, 2024 · 4 comments
Open
2 tasks done

Comments

@phyyuel
Copy link

phyyuel commented Dec 24, 2024

Component

TabList

Package version

9.6.2

React version

17.0.1

Environment

Edge chromium latest version

Current Behavior

When using subtle-circular/filled-circular appearance in high contrast aquatic or dessert theme, it is hard to differentiate what tab is selected in the tablist.
Image

This is mostly due to having no background color for selected tab in these theme.

Expected Behavior

The selected tab should be visually obvious in high contrast or dessert mode.

Reproduction

https://react.fluentui.dev/?path=/docs/components-tablist--docs#appearance

Steps to reproduce

  1. Navigate to the demo page: https://react.fluentui.dev/?path=/docs/components-searchbox--docs, select a tab in the demo
  2. Switch computer theme via windows->settings->Accesscibility->Contrast theme. Select Contrast theme to either Aquatic or Dessert
  3. View the demo page and see the selected tab

Are you reporting an Accessibility issue?

Yes

Suggested severity

High - No workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@sopranopillow
Copy link
Contributor

Makes sense, I think adding the background to match the regular look would help ensure it's understandable. I checked the spec for the circular and it seems like the expectations for HCM were not added, we should double check with a designer before doing this.

@phyyuel
Copy link
Author

phyyuel commented Dec 27, 2024

@sopranopillow Is there a way to track the progress? This is critical to our product's A11y review

@sopranopillow sopranopillow added the Component: TabList TabList control label Dec 27, 2024
@sopranopillow
Copy link
Contributor

sopranopillow commented Dec 27, 2024

I've assigned it to the team in charge of v9 (cxe-prg) who will triage accordingly, all updates will happen here. If you would like, you could file this issue in here as well: https://dev.azure.com/microsoftdesign/fluent-ui/_wiki/wikis/fluent-ui.wiki/193/Partner-A11y-Issue-Filing-Process (internal link in case you're in MS)

@phyyuel
Copy link
Author

phyyuel commented Dec 27, 2024

Thanks. Issue fired: https://dev.azure.com/microsoftdesign/fluent-ui/_workitems/edit/24802

@dmytrokirpa dmytrokirpa self-assigned this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants