Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Screen reader is reading content outside of the dialog after first load #33438

Closed
2 tasks done
MirandaGe opened this issue Dec 10, 2024 · 1 comment
Closed
2 tasks done

Comments

@MirandaGe
Copy link
Member

Component

Dialog

Package version

9.56.3

React version

17.0.1

Environment

Edge chromium latest version
Narrator latest version

Current Behavior

After open a dialog, screen reader will read out content behind the dialog. See video (issue start after 20s)

Expected Behavior

Content outside Dialog should not be read out.

Reproduction

https://react.fluentui.dev/?path=/docs/components-dialog--docs

Steps to reproduce

  1. Open Narrator
  2. Navigate to the demo page: https://react.fluentui.dev/?path=/docs/components-dialog--docs, open a dialog, wait for screen reader to finish reading.

Are you reporting an Accessibility issue?

yes

Suggested severity

High - No workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@smhigley
Copy link
Contributor

Hi @MirandaGe, thanks for testing accessibility! Our docs site renders the examples in an iframe, with the Storybook navigation existing outside of it (that left pane that Narrator navigated to after the dialog in your video). Examples in the content section of the page cannot affect UI outside of it. I believe this is the default behavior of Storybook (the framework we use for our docs site), and since these are sandboxed examples, I don't think there's much of a need to change that behavior.

Just by the nature of iframes, script within them cannot affect anything outside the iframe / cannot cross iframe boundaries. Our Dialog is correctly hiding all background content within its own page. If you have a Dialog or other modal in a web page with iframes and you want that modal to affect UI across iframes, you would need to add custom script.

Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants