Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font subsetting plugin bug #684

Closed
ColeStansbury opened this issue Jan 22, 2024 · 2 comments
Closed

Font subsetting plugin bug #684

ColeStansbury opened this issue Jan 22, 2024 · 2 comments
Assignees

Comments

@ColeStansbury
Copy link

ColeStansbury commented Jan 22, 2024

There appears to be a number of icons which are not rendering correctly when using the webpack subsetting plugin.

With plugin:
image

Without plugin:
image

Examples include
LineHorizontal416Filled
LineHorizontal320Filled
MoreVertical16Filled
MoreHorizontal16Filled

... and others

@tomi-msft
Copy link
Contributor

Hi @ColeStansbury. This occurs because the plugin is trying to maintain the styles present in the svg icons by using style injection into the styles prop of the font icons. This has been fixed in the most recent version.

@tomi-msft tomi-msft self-assigned this Mar 6, 2024
@ColeStansbury
Copy link
Author

Thanks! I don't see this problem in 2.0.242 anymore

the subset plugin remains volatile though - see #723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants