Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run full refresh on incremental models with v1.8.1 #257

Open
byrontuckett opened this issue Oct 13, 2024 · 1 comment
Open

Unable to run full refresh on incremental models with v1.8.1 #257

byrontuckett opened this issue Oct 13, 2024 · 1 comment

Comments

@byrontuckett
Copy link

Incremental models using v1.8.1 of this adapter cannot be full refreshed - details microsoft/dbt-fabric#179.

microsoft/dbt-fabric@6f5acc5 addresses the issue in the upstream dbt-fabric adapter v1.8.7, however dbt-synapse v1.8.1 references dbt-fabric==1.8.6 and so the patched version 1.8.7 is not used by the adapter.

(setup.py)[https://github.com/microsoft/dbt-synapse/blob/224b7b4f0788a5ec02c39a8a173b7a8da06621c4/setup.py#L19]

dbt_fabric_requirement = "dbt-fabric==1.8.6"

Good news is, currently master branch has the fixed dbt_fabric_requirement version specification. May I please ask that a patch release is cut to PyPi so we can utilize this fix from PyPi.

setup.py

dbt_fabric_requirement = "dbt-fabric>=1.8.6,<2.0"

@dataders @prdpsvs Thank you!! 👍🏼

@byrontuckett
Copy link
Author

@prdpsvs can you please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant