String Comparisons

[FMCalisto]

Position literals first in String comparisons.

42
43     public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException {
44         context = callbackContext;
45         if(action.equals("getPermission"))
46         {
47             if(hasPermisssion())

Why is this an issue?

Position literals first in comparisons, if the second argument is null then NullPointerExceptions can be avoided, they will just return false.

Ex:

class Foo {
  boolean bar(String x) { //it will throw a nullPointer if x is null
    return x.equals("2");
  }

  boolean bar2(String x) { //this way it will return false even if x is null
    return "2".equals(x);
  }
}

Source

Related code pattern

Enforces literals first in comparisons

Enforces literals to be positioned first in comparisons.