From 64a08574d5b086574170da7eb02f00abe05ffcb7 Mon Sep 17 00:00:00 2001 From: Shiran Rubin Date: Tue, 31 Oct 2023 12:35:25 +0200 Subject: [PATCH] Revert "Upgrade linkcheck (#1000)" This reverts commit ebc0dc7c46221eef7d3f414c7a2ce6e7069f78fd. --- .github/workflows/mega-linter.yml | 25 +++---------------- .mega-linter.yml | 4 +-- .../collaboration/why-collaboration.md | 2 +- docs/design/temp.md | 2 -- docs/privacy/data-handling.md | 4 +-- linkcheck.json | 8 ++---- 6 files changed, 10 insertions(+), 35 deletions(-) delete mode 100644 docs/design/temp.md diff --git a/.github/workflows/mega-linter.yml b/.github/workflows/mega-linter.yml index 8118b5f629..c021872bad 100644 --- a/.github/workflows/mega-linter.yml +++ b/.github/workflows/mega-linter.yml @@ -1,6 +1,6 @@ --- # MegaLinter GitHub Action configuration file -# More info at https://megalinter.io +# More info at https://oxsecurity.github.io/megalinter name: MegaLinter on: @@ -32,14 +32,6 @@ jobs: token: ${{ secrets.PAT || secrets.GITHUB_TOKEN }} fetch-depth: 0 -# - name: List Files -# run: ls -R - -# - name: Download linkcheck artifact -# uses: actions/download-artifact@v3 -# with: -# name: linkcheck_cache - # MegaLinter - name: MegaLinter id: ml @@ -48,13 +40,14 @@ jobs: uses: oxsecurity/megalinter@v7.1.0 env: # All available variables are described in documentation - # https://megalinter.io/latest/config-file/ + # https://oxsecurity.github.io/megalinter/configuration/ VALIDATE_ALL_CODEBASE: true # Set ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} to validate only diff with main branch GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # ADD YOUR CUSTOM ENV VARIABLES HERE TO OVERRIDE VALUES OF .mega-linter.yml AT THE ROOT OF YOUR REPOSITORY # Upload MegaLinter artifacts - name: Archive production artifacts + if: ${{ success() }} || ${{ failure() }} uses: actions/upload-artifact@v2 with: name: MegaLinter reports @@ -62,18 +55,6 @@ jobs: megalinter-reports mega-linter.log - - name: List Files - run: ls -R - - - name: Save linkcheck cache - uses: actions/upload-artifact@v2 - with: - name: linkcheck_cache - path: megalinter-reports/linkcheck/cache - - - name: List Files - run: ls -R - # Create pull request if applicable (for now works only on PR from same repository, not from forks) - name: Create Pull Request with applied fixes id: cpr diff --git a/.mega-linter.yml b/.mega-linter.yml index 979c9dd9c6..e1d2243b76 100644 --- a/.mega-linter.yml +++ b/.mega-linter.yml @@ -1,6 +1,6 @@ --- # Configuration file for MegaLinter -# See all available variables at https://megalinter.io/latest/config-file/ and in linters documentation +# See all available variables at https://oxsecurity.github.io/megalinter/configuration/ and in linters documentation APPLY_FIXES: all # all, none, or list of linter keys # ENABLE: # If you use ENABLE variable, all other languages/formats/tooling-formats will be disabled by default @@ -25,4 +25,4 @@ LOG_LEVEL: WARNING MARKDOWN_MARKDOWN_LINK_CHECK_ARGUMENTS: "-q" # DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass PLUGINS: - - https://raw.githubusercontent.com/shiranr/linkcheck/v2.0.4.beta/mega-linter-plugin-linkcheck/linkcheck.megalinter-descriptor.yml + - https://raw.githubusercontent.com/shiranr/linkcheck/main/mega-linter-plugin-linkcheck/linkcheck.megalinter-descriptor.yml diff --git a/docs/agile-development/advanced-topics/collaboration/why-collaboration.md b/docs/agile-development/advanced-topics/collaboration/why-collaboration.md index 33ae8f360d..fb6d52be44 100644 --- a/docs/agile-development/advanced-topics/collaboration/why-collaboration.md +++ b/docs/agile-development/advanced-topics/collaboration/why-collaboration.md @@ -79,4 +79,4 @@ Knowledge sharing and bringing ISE and customer engineers together in a ‘code- - [Pair Programming hands-on lessons](https://github.com/The-V8/pair-programming-sessions) - these can be used (and adapted) to support bringing pair programming into your team (MS internal or including customers) -- [Effortless Pair Programming with GitHub Codespaces and VSCode](./pair-programming-tools.md) +- [Effortless Pair Programming with GitHub Codespaces and VSCode](./pair-programming-tools.md) \ No newline at end of file diff --git a/docs/design/temp.md b/docs/design/temp.md deleted file mode 100644 index 67d81e9de0..0000000000 --- a/docs/design/temp.md +++ /dev/null @@ -1,2 +0,0 @@ -This is a test file to be deleted!!! -[link](https://github.com/orgs/community/discussions/26672) \ No newline at end of file diff --git a/docs/privacy/data-handling.md b/docs/privacy/data-handling.md index 23e3eaaebb..cf1301d60a 100644 --- a/docs/privacy/data-handling.md +++ b/docs/privacy/data-handling.md @@ -101,7 +101,7 @@ relevant and limited to what is necessary in relation to the purposes for which This is particularly important for personal data. Once you have personal data there are many rules and regulations that apply, some examples of these might be HIPPA, GDPR, CCPA. The customer should be aware of and surface any applicable regulations that apply to their data. -Furthermore the [seven principles of privacy by design](https://www.onetrust.com/blog/principles-of-privacy-by-design/) +Furthermore the [seven principles of privacy by design](https://privacy.ucsc.edu/resources/privacy-by-design---foundational-principles.pdf) should be reviewed and considered when handling any type of sensitive data. ## Resources @@ -112,4 +112,4 @@ should be reviewed and considered when handling any type of sensitive data. - [FAQ and White Papers](https://servicetrust.microsoft.com/ViewPage/TrustDocuments?command=Download&docTab=6d000410-c9e9-11e7-9a91-892aae8839ad_AuditedControls) - [Microsoft Compliance Offerings](https://learn.microsoft.com/en-us/compliance/regulatory/offering-home?view=o365-worldwide) - [Accountability Readiness Checklists](https://learn.microsoft.com/en-us/compliance/regulatory/gdpr-arc?view=o365-worldwide#gdpr-compliance-controls) -- [Privacy by Design The 7 Foundational Principles](https://www.onetrust.com/blog/principles-of-privacy-by-design/) +- [Privacy by Design The 7 Foundational Principles](https://privacy.ucsc.edu/resources/privacy-by-design---foundational-principles.pdf) diff --git a/linkcheck.json b/linkcheck.json index 8438aa07c5..47d966aa2e 100644 --- a/linkcheck.json +++ b/linkcheck.json @@ -53,11 +53,7 @@ "https://mtirion.medium.com/", "https://chrieke.medium.com/", "https://eclipse.dev/mat/", - "https://cloud.google.com/blog/products/gcp/cre-life-lessons-what-is-a-dark-launch-and-what-does-it-do-for-me", - "https://miro.com/guides/retrospectives/ideas-games", - "https://interpret.ml/" + "https://cloud.google.com/blog/products/gcp/cre-life-lessons-what-is-a-dark-launch-and-what-does-it-do-for-me" ], - "only_errors": false, - "cache_duration": "24h", - "cache_output_path": "megalinter-reports/linkcheck/cache" + "only_errors": true } \ No newline at end of file