Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors exposed by the implicit inclusion of checked header files. #109

Open
sulekhark opened this issue Mar 11, 2021 · 1 comment

Comments

@sulekhark
Copy link
Contributor

For the following benchmarks, -DNO_IMPLICIT_INCLUDE_CHECKED_HDRS had to be added in their Makefiles to avoid compilation errors at present.

Cause of compilation error: A function with a bounds-safe interface has another function call as an argument at one of its call-sites.
MultiSource/Benchmarks/BitBench/drop3
MultiSource/Benchmarks/FreeBench/pifft
MultiSource/Benchmarks/McCat/18-imp
MultiSource/Benchmarks/Prolangs-C/TimberWolfMC
MultiSource/Benchmarks/Prolangs-C/agrep
MultiSource/Benchmarks/Prolangs-C/assembler
MultiSource/Benchmarks/Prolangs-C/loader
MultiSource/Benchmarks/Prolangs-C/unix-smail
MultiSource/Benchmarks/Ptrdist/bc
MultiSource/Benchmarks/VersaBench/dbms

Cause of compilation error: Some of the variables/strings (like ON and n) used by Checked-C-specific declarations have been redefined as macros earlier + plus other issues.
MultiSource/Benchmarks/MallocBench/espresso
MultiSource/Benchmarks/McCat/05-eks
MultiSource/Benchmarks/MiBench/consumer-lame
MultiSource/Benchmarks/MiBench/consumer-typeset
MultiSource/Benchmarks/MiBench/network-patricia
MultiSource/Benchmarks/MiBench/office-ispell
MultiSource/Benchmarks/Prolangs-C/archie-client
MultiSource/Benchmarks/Prolangs-C/cdecl
MultiSource/Benchmarks/Trimaran/netbench-url

sulekhark added a commit that referenced this issue Mar 11, 2021
…compilations that were failing

because of implicit inclusion of checked headers.
Filed bug #109 to track this issue.
@sulekhark
Copy link
Contributor Author

The first set of ten benchmarks whose compilation was failing because a side-effecting argument expression is used for function parameters used in return bounds expression, are now fixed because of the fix to issue #1009 in checkedc-clang repo.

sulekhark added a commit that referenced this issue Apr 1, 2021
* Added the compilation flag -DNO_IMPLICIT_INCLUDE_CHECKED_HDRS to the compilations that were failing
because of implicit inclusion of checked headers.
Filed bug #109 to track this issue.

* Now that implicit inclusion of checked header files is the default, modified
explicit inclusion to implicit inclusion.

* The fix to #1009 in checkedc-clang has eliminated the need for this flag
in the make files of these projects.

* Keeping CMakeLists.txt up-to-date with the changes to Makefile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant