Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Federated Identity Credential #4632

Closed
XVincentX opened this issue Mar 13, 2024 · 6 comments · Fixed by #4765
Closed

Support Federated Identity Credential #4632

XVincentX opened this issue Mar 13, 2024 · 6 comments · Fixed by #4765
Assignees
@ceciliaavila
Labels
feature-request A request for new functionality or an enhancement to an existing one.

Comments

@XVincentX
Copy link
Member

XVincentX commented Mar 13, 2024 •
edited
Loading

Right now botframework supports authentication using Password or Certificate. It has been possible for a while now to authenticate as an App Registration using Federated Identity Credential - which is not supported by botframework yet
@XVincentX XVincentX added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels Mar 13, 2024
@tracyboehrer tracyboehrer removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Apr 2, 2024
@tracyboehrer
Copy link
Member

Thanks for your input. This is more than a Bot Framework SDK change, and not something that is currently on the roadmap.

@XVincentX
Copy link
Member Author

Is it really? From my understanding no service requires any change. The SDK would just need to support authentication through ClientAssertion instead of just accepting a Certificate or a Client Secret

@tracyboehrer
Copy link
Member

@ceciliaavila Port from DotNet SDK. This is for MS Tenant only though.

microsoft/botbuilder-dotnet#6838

@XVincentX
Copy link
Member Author

@ceciliaavila @tracyboehrer I would be interested in contributing (either via writing the code or testing the feature as soon as it out). I could really get rid of these certificates in my application

@ceciliaavila
Copy link
Collaborator

@ceciliaavila @tracyboehrer I would be interested in contributing (either via writing the code or testing the feature as soon as it out). I could really get rid of these certificates in my application

Hi @XVincentX, we are working on the port, we'll let you know as soon as it's ready for testing.

@sw-joelmut sw-joelmut mentioned this issue Oct 8, 2024
Merged
tracyboehrer pushed a commit that referenced this issue Oct 8, 2024
@sw-joelmut
port: [#4632] Support Federated Identity Credential (#4765)
021429c 
* Add FIC support

* Fix lint

* Add appId validation
@XVincentX
Copy link
Member Author

This is great news. @tracyboehrer is this published somewhere as beta to try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
feature-request A request for new functionality or an enhancement to an existing one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4632] Support Federated Identity Credential microsoft/botbuilder-js
3 participants
@tracyboehrer @XVincentX @ceciliaavila