Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeModulesReferenceDetector is too aggressive... #41

Open
kenotron opened this issue Oct 9, 2020 · 1 comment
Open

NodeModulesReferenceDetector is too aggressive... #41

kenotron opened this issue Oct 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@kenotron
Copy link
Member

kenotron commented Oct 9, 2020

Many webpack.config.js module.rules loader configurations would have an explicit excludes of a /node_modules/ pattern. We should allow these kinds of references. I think maybe we should only have the detector deal with things inside a require() or import statement. This will make the rule not catch 100% of stuff, but it can at least allow the proper uses of these node_modules appearances. Alternative is to have disable-single-line kind of thing so that we don't have to disable the entire rule altogether.
@jdhuntington jdhuntington added the enhancement New feature or request label Nov 16, 2020
@kelseyyoung
Copy link

This feature seems to have been implemented (with boll-disable), can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdhuntington @kenotron @kelseyyoung