Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Assess HTML report groups requirements incorrectly #6994

Open
madalynrose opened this issue Sep 26, 2023 · 8 comments
Open

Quick Assess HTML report groups requirements incorrectly #6994

madalynrose opened this issue Sep 26, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@madalynrose
Copy link
Contributor

Describe the bug

The generated HTML report for Quick Assess currently uses the same summary model as Assessment. The assessment summary model groups requirements by Assessment. This means that the test details here display the Assessment title, not requirement titles. It also means that if any requirements are part of the same Assessment, they appear together and that the order of requirements is not respected in this list.

Expected behavior

Test details list requirements by name and show one requirement per title. It should instead use the Quick Assess summary model, as used on the Overview page for Quick Assess.

Screenshots

quick assess report with a red circle around "Headings", which has two circles indicating requirements

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

N/A

Additional context

N/A

@madalynrose madalynrose added the bug Something isn't working label Sep 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Sep 26, 2023
@madalynrose madalynrose moved this from Needs triage to Accepted in Accessibility Insights Oct 2, 2023
@thesharifi
Copy link

@madalynrose, I ma interested in this repo, please assign this to me.

@shanmukhasaisai
Copy link

Hello there!

I'm interested in working on this issue. Could you please assign it to me?

@JGibson2019 JGibson2019 assigned thesharifi and unassigned codeofdusk Nov 13, 2023
@JGibson2019 JGibson2019 removed the status: new This issue is new and requires triage by DRI. label Nov 13, 2023
@JGibson2019
Copy link
Contributor

@thesharifi we've assigned the bug to you. If you're no longer interested, let us know and we'll assign it to the other user who showed interest.

@JGibson2019 JGibson2019 moved this from Accepted to Accepted - external in Accessibility Insights Nov 13, 2023
@DaveTryon
Copy link
Contributor

DaveTryon commented Nov 13, 2023

Implementation note: Please don't change the report package in any way, since it's used by other packages that we create. The optimal path forward may be to leverage the code from get-quick-assess-summary-model.tx from AssessmentsProviderImpl so that the results are properly grouped when running from the QuickAssess. Once the results are correctly grouped, that should be automatically reflected in the report package.

@DaveTryon
Copy link
Contributor

@thesharifi, any update on this? We might want to assign to someone else if it's not going to happen anytime soon

@DaveTryon
Copy link
Contributor

@shanmukhasaisai, are you still interested in working on this? The first person to volunteer seems to have lost interest

@shanmukhasaisai
Copy link

Yes, iam interested to work

@DaveTryon
Copy link
Contributor

@shanmukhasaisai, Sorry for the delay in getting back to you. If you're still available, please take this and run with it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Accepted - external
Development

No branches or pull requests

6 participants