Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] AIWeb skips unresponsive iframes #6347

Open
sfoslund opened this issue Jan 13, 2023 · 5 comments
Open

[Tracking] AIWeb skips unresponsive iframes #6347

sfoslund opened this issue Jan 13, 2023 · 5 comments
Labels
bug Something isn't working status: await community interest Waiting for community engagement to prioritize status: blocked This issue is blocked.

Comments

@sfoslund
Copy link
Member

Describe the bug

Our extension makes a best-effort attempt to scan child iframes - we send messages to the child frame and wait for a small timeout. If the child frame does not respond by our timeout, we skip the child iframe. This is a tracking issue for cases when the extension skips child iframes unexpectedly.

If you are running into this issue, please comment below with the following information:

  • Steps to reproduce the behavior
  • A target site URL or code pen repro example
  • OS Name & Version (e.g. Windows 10.0.18363 Build 18363 / macOS Catalina 10.15(19A583))
  • AI-Web Version & Environment (e.g. 1.140.1 Insider)
  • Browser Version (e.g. Google Chrome 78.0.3904.108 (Official Build) (64-bit))
  • [Optional] Screenshots, additional context

Context

The purpose of this issue is to track all known instances of AI web skipping iframes unexpectedly. It is pointed to in the iframe skipped warning banner, added in #6330

@sfoslund sfoslund added the bug Something isn't working label Jan 13, 2023
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Jan 13, 2023
@ghost ghost assigned jlperkins Jan 13, 2023
@jlperkins jlperkins added status: await community interest Waiting for community engagement to prioritize and removed status: new This issue is new and requires triage by DRI. labels Jan 13, 2023
@ferBonnin
Copy link
Contributor

we will monitor every week for a month and revisit if needed

@DaveTryon DaveTryon added the status: blocked This issue is blocked. label Apr 26, 2023
@gavinbarron
Copy link

This has started to show up as an issue when testing components within our Storybook site for Microsoft Graph Toolkit.

Load this url: https://mgt.dev/?path=/story/components-mgt-agenda--simple
Wait for the page to load and then run a FastPass scan.

OS: Windows 11 Enterprise
Version: 22H2
Build: 22621.1702

AI-Web Version: 2.38.1

Browser: Microsoft Edge for Business
Version 114.0.1823.30 (Official build) beta (64-bit)

Is there any known work arounds I could look into?

@DaveTryon DaveTryon moved this from Needs Triage to Old backlog in Accessibility Insights Jun 28, 2023
@DaveTryon DaveTryon moved this from Old backlog to Needs triage in Accessibility Insights Jul 28, 2023
@DaveTryon DaveTryon moved this from Needs triage to Accepted in Accessibility Insights Jul 31, 2023
@DaveTryon
Copy link
Contributor

DaveTryon commented Nov 3, 2023

Hi, @gavinbarron! We've looked into this, and StoryBook's IFrames can't be scanned by Accessibility Insights for Web. StoryBook is sort of an artificial hosting environment, so we don't recommend it as a test bed for assessing the accessibility of your controls. You'll get a much more meaningful result by hosting your control in a simple test page and scanning that page using Accessibility Insights for Web.

As an alternative, StoryBook has an accessibility add-on that is intended to provide accessibility testing within StoryBook. This add-on is based on axe-core (the same engine used by Accessibility Insights for Web), but because it uses a 2020 version of axe-core, its results may be somewhat behind current WCAG standards.

Thanks for using Accessibility Insights!

@TaliHausner
Copy link

Hi,

  1. Steps to reproduce the behavior -can't run the accessibility insight tool with fast pass on my react blade
  2. A target site URL or code pen repro example - https://ms.portal.azure.com/?feature.securityGraphDebug=true%2F#view/Microsoft_Azure_Security/SecurityMenuBlade/~/AscInformationProtection
  3. OS Name & Version (e.g. Windows 10.0.18363 Build 18363 / macOS Catalina 10.15(19A583)) - windows 11 enterprise
  4. AI-Web Version & Environment (e.g. 1.140.1 Insider)
  5. Browser Version (e.g. Google Chrome 78.0.3904.108 (Official Build) (64-bit)) - not working in chrome and in edge browsers
  6. [Optional] Screenshots, additional context
    screenshots of the blade and the error:

dsdsdsdsdsdsd

Screenshot 2023-11-15 125334

@gardnerjr
Copy link

@TaliHausner did you ever get more followup on this? we are now seeing this in some of our reactview blades in the azure portal as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: await community interest Waiting for community engagement to prioritize status: blocked This issue is blocked.
Projects
Status: Accepted
Development

No branches or pull requests

7 participants