Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad-hoc visualization state becomes inconsistent after toggling extension off and on #6256

Open
dbjorge opened this issue Dec 7, 2022 · 5 comments
Open

ad-hoc visualization state becomes inconsistent after toggling extension off and on #6256

dbjorge opened this issue Dec 7, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@dbjorge
Copy link
Contributor

dbjorge commented Dec 7, 2022

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Activate ad-hoc automated checks on any page with issues
  2. from the browser's manage extension page, toggle the extension off and on
  3. open the popup ad-hoc tools panel
    4 note that visualization is not visible on the page, but the toggle control for the automated checks tool is "on"

CodePen repro example

n/a

Expected behavior

The state of the toggle control should be consistent with whether visualizations are active on the page. I don't think it matters particularly whether the visualization ends up "on" or "off" at the end of these steps, but it shouldn't be self-inconsistent.

Screenshots

screenshot of deque mars test page in state where automated checks is toggled on in the ad hoc panel but no failure highlight boxes are visible

Context (please complete the following information)

  • OS Name & Version: Repros on both Windows 11 22621.819 and Mac 13.0.1
  • AI-Web Version & Environment: Repros on both 2.36.0 insider and 2.35.0 Production
  • Browser Version: Repros on both Chrome beta 109.0.5414.25 and Edge stable 108.0.1462.42
  • Target Page: any

Are you willing to submit a PR?

yes

Did you search for similar existing issues?

yes

Additional context

found during "Verify deprecated page functionality" validation scenario for 2.36.0, but probably non-blocking (not a regression)
@dbjorge dbjorge added the bug Something isn't working label Dec 7, 2022
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Dec 7, 2022
@ghost ghost assigned codeofdusk Dec 7, 2022
@codeofdusk codeofdusk added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Dec 7, 2022
@ghost ghost assigned ferBonnin Dec 7, 2022
@ghost
Copy link

ghost commented Dec 7, 2022

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label Dec 13, 2022
@ghost ghost removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Dec 13, 2022
@ferBonnin
Copy link
Contributor

this is a corner case so let's timebox addressing this issue to 4 hours and close if not.

@dbjorge
Copy link
Contributor Author

dbjorge commented Dec 13, 2022

If we do end up closing due to the timebox, we should update our release validation steps accordingly, since validating that this doesn't happen is an explicit part of step 1 from the "Verify 'deprecated page' functionality" release scenario

@DaveTryon DaveTryon moved this from Needs Triage to Old backlog in Accessibility Insights Jun 28, 2023
@DaveTryon DaveTryon moved this from Old backlog to Accepted in Accessibility Insights Jun 28, 2023
@DaveTryon DaveTryon added active (Dev) The assigned dev is working to perform the work. and removed status: ready for work This issue is ready to be worked on. labels Jun 30, 2023
@DaveTryon
Copy link
Contributor

@madalynrose started working on this in https://github.com/madalynrose/accessibility-insights-web/tree/adhoc-toggles-state-fix, then shelved it for more pressing issues. If someone else picks this up, please discuss with @madalynrose before proceeding.

@DaveTryon DaveTryon removed the active (Dev) The assigned dev is working to perform the work. label Sep 27, 2023
@thesharifi
Copy link

@madalynrose I am interested in working on this repo, please assign this to me.

@madalynrose madalynrose mentioned this issue Aug 29, 2024
Merged
5 tasks
madalynrose added a commit that referenced this issue Sep 4, 2024
@madalynrose
fix: ad-hoc visualization state becomes inconsistent after toggling e…
af8b586 
…xtension off and on (#7433)

#### Details

This PR adjusts the logic for setting extension initial state so that
the toggles are always off (reflecting reality because the
visualizations will never be active on extension start).

##### Motivation

Addresses #6256

##### Context


#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue: #6256
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.

Co-authored-by: Madalyn Parker <[email protected]>
@madalynrose madalynrose moved this from Accepted to Needs release in Accessibility Insights Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Accessibility Insights
Status: Needs release
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbjorge @codeofdusk @madalynrose @ferBonnin @DaveTryon @thesharifi