Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explanations for failures in lists of instances #485

Open
hollsk opened this issue Apr 1, 2019 · 10 comments
Open

Allow explanations for failures in lists of instances #485

hollsk opened this issue Apr 1, 2019 · 10 comments
Assignees
Labels
feature request hacktoberfest This issue welcomes contributions for Hacktoberfest help wanted Extra attention is needed

Comments

@hollsk
Copy link

hollsk commented Apr 1, 2019

Is your feature request related to a problem? Please describe.

Some of the categories produce a list of elements on the page that you can mark as a pass or fail. Sometimes it's not immediately obvious to another person why you've marked a particular instance as a fail.

e.g. I might want to fail <h1><img src="logo.gif" alt="Project Name"></h1> under "Headings -> Heading function" because the alt text doesn't describe the purpose of the page and shouldn't be a heading.

I might also want to fail <img src="logo.gif" alt="header logo"> under "Images -> Text alternative" because the alt text doesn't have parity with the text in the logo.

Currently there's no way for me to actually say that in the report - I just have to mark it as a fail and hope the person reviewing the report (who might be the same person who implemented the original code!) understands the problem.

Describe the desired outcome

It'd be good to be able to add a comment in lists of instances (e.g. headings, images) to make it clear in the exported report why an item has been flagged.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

This is a fantastic tool, thanks so much for your hard work on it! 😄

@msft-github-bot msft-github-bot added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Apr 1, 2019
@ferBonnin ferBonnin self-assigned this Apr 1, 2019
@risanaka risanaka added status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. and removed Needs PM Consultation labels Apr 1, 2019
@risanaka risanaka removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Apr 2, 2019
@Sirisha-Kommushetty Sirisha-Kommushetty added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. labels Jul 17, 2019
@msft-github-bot
Copy link
Collaborator

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ferBonnin ferBonnin added help wanted Extra attention is needed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Jul 25, 2019
@msft-github-bot
Copy link
Collaborator

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

@ferBonnin
Copy link
Contributor

Thanks for the feature request @hollsk! We will add the tag "needs help" and if someone in the community wants to help make this happen we can provide the mock-ups for this.

Some additional thoughts on this, we already have a panel to add a comment for manual instances, so that can be re-utilized for this. Each element row will need to have a way to add a comment as well as an indicator that there is a comment. The report will need to add a comment for the failure instances that have a comment. Also need to consider that if an instance is marked as pass then the user cannot add a comment (currently passed instances are not listed in the report)

@joppekroon
Copy link

After doing my first assessment this was my main problem with the tool.

From a user perspective it is weird that some checks have the option for comments, and others do not. This requires you to have an accompanying document to record your comments anyway, reducing the usefulness of the report and the comments that you can add.

Additionally, there were cases where I wanted to explain why I passed a certain check, so I don't agree at this point with the idea that you shouldn't be able to add a comment when the item/check is marked passed.

@ferBonnin
Copy link
Contributor

Thanks for your feedback @joppekroon! After taking a look, we do send the details of a pass instance into the report, so a comment for passed or failed instance could be in the report.

We have marked this issue as "needs help" in case someone in the community wants to take a look :)

@ebarrette-lhob
Copy link

+1 for this feature request. Excellent tool can be made better with comments feature added to all manual tests pass or fail.

@ssawczyn
Copy link

Absolutely love this suggestion, would be extremely handy to optionally be able to add comments in order to provide additional context around why something is marked as a failure, or possible remediation guidance to promote consistency.

@madalynrose madalynrose added the hacktoberfest This issue welcomes contributions for Hacktoberfest label Oct 7, 2022
@Pranav-yadav

This comment was marked as outdated.

@DaveTryon DaveTryon moved this from Needs Triage to Help Wanted in Accessibility Insights Jun 26, 2023
@DaveTryon DaveTryon moved this from Help Wanted to Old backlog in Accessibility Insights Jun 28, 2023
@katannshaw
Copy link

+1 to this request. It's the one issue I have with this tool. If I could add notes to each pass/fail instance, it would be almost perfect.

@DaveTryon DaveTryon moved this from Old backlog to Help wanted in Accessibility Insights Jul 14, 2023
@DaveTryon DaveTryon removed the status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. label Jul 14, 2023
@anipv
Copy link

anipv commented Oct 16, 2023

+1 to this request. Looks like there has been a request for this feature since 2019. We are now into October 2023. Please consider adding this feature. If I could add notes to each pass/fail instance, it would be almost perfect.
Ability to add comments, if needed, in lists of instances when an item is flagged as a failure. #7017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request hacktoberfest This issue welcomes contributions for Hacktoberfest help wanted Extra attention is needed
Projects
Status: Help wanted
Development

No branches or pull requests