Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left nav lacks clear tab or focus indicators with Windows HC modes #4263

Open
DaveTryon opened this issue May 22, 2021 · 6 comments
Open

Left nav lacks clear tab or focus indicators with Windows HC modes #4263

DaveTryon opened this issue May 22, 2021 · 6 comments
Assignees
Labels
bug Something isn't working category: accessibility Accessibility Issues needs Dev This issue is ready for dev to perform the work. status: ready for work This issue is ready to be worked on.

Comments

@DaveTryon
Copy link
Contributor

Describe the bug

If you enable a Windows HC mode, the left nav pane loses both the hover indicator and the current selection indicators

To Reproduce
Steps to reproduce the behavior:

  1. Start an assessment on a page (I used )
  2. Hover over the assessment steps in the nav pane -- there's no strong visual feedback (except the tooltip if you pause long enough)
  3. Select an item in the list--there should be a clear indicator that it's selected, but the only indication seems to be a bolding of text (which is much harder to discern than the non-HC version)
  4. See error

Alternatively, run FastPass--all 3 steps in the nav bar look more or less the same

CodePen repro example

Expected behavior

There should be clearly visible counterparts of the selection in HC modes

Screenshots

In these screenshots, the mouse hover is on "3 Focus", and the selection is on "3.1 Visible Focus". The only The Black-based HC themes show a "thumb"

HC Mode Screenshot
None image
HC 1 image
HC 2 image
HC Black image
HC White image

Context (please complete the following information)

Are you willing to submit a PR?

Did you search for similar existing issues?

Additional context

@DaveTryon DaveTryon added the bug Something isn't working label May 22, 2021
@ghost ghost added the status: new This issue is new and requires triage by DRI. label May 22, 2021
@ghost ghost assigned jalkire May 22, 2021
@DaveTryon DaveTryon changed the title Left nav lacks visible tab or strong focus indicators with Windows HC modes Left nav lacks clear tab or focus indicators with Windows HC modes May 22, 2021
@jalkire jalkire added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 24, 2021
@ghost ghost assigned ferBonnin May 24, 2021
@ghost
Copy link

ghost commented May 24, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: new This issue is new and requires triage by DRI. label May 24, 2021
@jalkire jalkire removed their assignment May 24, 2021
@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label May 24, 2021
@ghost ghost removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 24, 2021
@ferBonnin
Copy link
Contributor

@ferBonnin needs some PM/ Design information

@ferBonnin ferBonnin added the status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. label May 24, 2021
@ghost
Copy link

ghost commented May 24, 2021

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: ready for work This issue is ready to be worked on. label May 24, 2021
@ferBonnin
Copy link
Contributor

@jlperkins could you please help us verify if this issue still repos after the Fluent update?

@jlperkins
Copy link
Contributor

jlperkins commented Apr 27, 2022

With the latest changes in main, and the new HC modes in Windows 11, this issue still repros. Note that I am unable to check on Windows 10 HC modes since I have already upgraded. For the Windows 11 modes, as seen in the images below, the assessment step gets a small colored bar to the side and text is bolded; but there is no strong indication that you have selected that test or are on that step of the assessment. This is different than in regular mode, where the entire nav item is highlighted a different color.

image
[Theme 1, Aquatic]

image
[Theme 2, Desert]

image
[Theme 3, Dusk]

image
[Theme 4, Night Sky]

@ferBonnin ferBonnin added the category: accessibility Accessibility Issues label Aug 2, 2022
@dbjorge dbjorge added status: ready for work This issue is ready to be worked on. and removed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. labels May 22, 2023
@DaveTryon DaveTryon moved this from Needs Triage to Old backlog in Accessibility Insights Jun 28, 2023
@DaveTryon DaveTryon moved this from Old backlog to Accepted in Accessibility Insights Jun 29, 2023
@DaveTryon DaveTryon added the needs Dev This issue is ready for dev to perform the work. label Jul 4, 2023
@DaveTryon DaveTryon moved this from Accepted to Accepted - vendor in Accessibility Insights Nov 20, 2023
@v-viyada
Copy link
Contributor

@nang4ally
Please review below screenshots if they are the desired outcomes for this bug or any changes required in this.

In these screenshots, the mouse hover is on "3 Focus", and the selection is on "3.1 Visible Focus"
[Theme 1 Aquatic]
image

[Theme 2 Desert]
image

[Theme 3 Dusk]
image

[Theme 4 Night Sky]
image

@peterdur FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: accessibility Accessibility Issues needs Dev This issue is ready for dev to perform the work. status: ready for work This issue is ready to be worked on.
Projects
Status: Accepted - vendor
Development

No branches or pull requests

7 participants