Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routines that were annotated with __drv_dispatchType(DRIVER_DISPATCH) are not seen as WdmCallbackRoutine or WdmDispatchRoutines #30

Open
finchnest opened this issue Sep 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@finchnest
Copy link
Contributor

finchnest commented Sep 1, 2022

__drv_dispatchType(DRIVER_DISPATCH)
__drv_dispatchType(IRP_MJ_CREATE)
__drv_dispatchType(IRP_MJ_SHUTDOWN)
NTSTATUS
CdFsdDispatch (
In PDEVICE_OBJECT DeviceObject,
Inout PIRP Irp
);

CdFsdDispatch, for example will not be caught by queries that look for WdmDispatchRoutines or WdmCallbackRoutines

@finchnest finchnest added the bug Something isn't working label Sep 1, 2022
@NateD-MSFT
Copy link
Contributor

I've been taking a look at this and it seems to me we need clarification on what a valid dispatch routine is w/r/t annotations and typedefs. Today our library only looks for the function to use the DRIVER_DISPATCH typedef, but it's unclear to me if PAfD would consider the above case to be a dispatch routine in analysis (and even if it does, if we should maintain that behavior.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants