-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5-browser-extension icon not updating #1303
Comments
/* Updated for Manifest V3- */ chrome.runtime.onMessage.addListener(function (msg, sender, sendResponse) { function drawIcon(value) {
} /* Updated manifest.json for Manifest V3: { /* Explanation:
By making these changes, your code should work with Manifest V3, and the error regarding setIcon should be resolved. */ |
This issue has not seen any action for a while! Closing for now, but it can be reopened at a later date. |
On the last task for the browser extension lesson, background.js has the following code segment:
`chrome.runtime.onMessage.addListener(function (msg, sender, sendResponse) {
if (msg.action === 'updateIcon') {
chrome.browserAction.setIcon({ imageData: drawIcon(msg.value) });
}
});
//borrowed from energy lollipop extension, nice feature!
function drawIcon(value) {
let canvas = document.createElement('canvas');
let context = canvas.getContext('2d');
}`
However when trying to run, the following error message is produced:
Error in event handler: TypeError: Cannot read properties of undefined (reading 'setIcon') at chrome-extension://fkcocajhgcibghcihihlnilegapombkl/background.js:3:24
I've tried debugging this on my own for hours, as well as going online to find answers for this bug. Apparently this code was written for Manifest V2, however the manifest.json supplied to us was written for Manifest V3, which means this code segment, and probably the whole file, is outdated. Please fix this issue to prevent more people from getting stuck on this step in the browser extension lesson.
The text was updated successfully, but these errors were encountered: