fix: Fixing OpenAIPrompt class to be able to work with older models like text-davinci-003 #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Ensuring that new prompt instances are created for each test. This will eliminate chance of one test interfering with another test. 2. Creating test to validate that for older model deployments, OpenAiCompletion instance is created in OpenAIPrompt class. 3. Fixing the bug that caused creation of OpenAICompletion object to fail. 4. Cleaning some code in OpenAIPrompt class.
FarrukhMasud
commented
Nov 22, 2024
cognitive/src/main/scala/com/microsoft/azure/synapse/ml/services/openai/OpenAIPrompt.scala
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2319 +/- ##
==========================================
- Coverage 84.50% 84.49% -0.01%
==========================================
Files 326 328 +2
Lines 16755 16771 +16
Branches 1480 1513 +33
==========================================
+ Hits 14158 14170 +12
- Misses 2597 2601 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| } | ||
|
|
||
|
|
||
| test("Validating OpenAICompletion and OpenAIChatCompletion for correctModels") { |
| @@ -307,4 +308,6 @@ abstract class OpenAIServicesBase(override val uid: String) extends CognitiveSer | |||
| } | |||
| super.getInternalTransformer(schema) | |||
| } | |||
|
|
|||
| private[openai] def prepareEntityAIService: Row => Option[AbstractHttpEntity] = this.prepareEntity | |||
There was a problem hiding this comment.
is this function necessary? seems like its not but hard to tell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While working with
OpenAIPromptclass, I discovered that this class does not work with older models. Upon investigation, I found that for models specified in the listlegacyModels, OpenAIPrompt class suppose to useOpenAICompletioninstance, for all other model deployment names,OpenAIChatCompletionclass is to be used. When setting parameter forOpenAICompletion, it tries to set parameters that are not available inOpenAICompletion, which causes instance creation to fail. There are no current unit tests or integration tests that verified this. In this PR, I am fixing this problem and adding unit test to validate this. I am also cleaning unit test and OpenAIPrompt class.What changes are proposed in this pull request?
In this PR I am:
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?