Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call DebugBreak when generating error codes #61

Open
derSeddy opened this issue May 10, 2022 · 0 comments
Open

Don't call DebugBreak when generating error codes #61

derSeddy opened this issue May 10, 2022 · 0 comments

Comments

@derSeddy
Copy link

When an error code is generated with MPIR_Err_create_code_valist the Visual Studio debugger will stop. This behavior is quite annoying for us because we are trying to open a file with mpio and it is a legitimate scenario that this fails because we don't have the user rights to open the file.
We only use msmpi by linking against the release DLL thus we consider this behavor to be unexpected.

This is the line of code:


We don't see a value in this behavior for end users, so we would just remove the line. But we think it would be fair to enclose it in #if DBG [...] #endif to at least only have the debugger stop when msmpi was build in debug mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant