Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding operation name via @Traced for MP rest client #151

Open
pavolloffay opened this issue Apr 16, 2019 · 7 comments
Open

Allow overriding operation name via @Traced for MP rest client #151

pavolloffay opened this issue Apr 16, 2019 · 7 comments

Comments

@pavolloffay
Copy link
Contributor

Traced annotation applied on a rest client method should override operation name.

@pavolloffay pavolloffay added this to the 1.4 milestone Apr 17, 2019
@pavolloffay
Copy link
Contributor Author

@fmhwong promised to implement this one.

@pavolloffay pavolloffay removed this from the 1.4 milestone Feb 7, 2020
@pilhuhn
Copy link
Contributor

pilhuhn commented Mar 16, 2020

Could this be implemented in SmallRye already?
Reading the spec chapter 3.1.3 I got the impression that this is already possible today.

@pilhuhn
Copy link
Contributor

pilhuhn commented Mar 16, 2020

Also I feel, that this should define more than just saying "can be overridden", but should include substitutions for otherwise provided things.

E.g. @Traced(operationName = "getMyBla %u") where %u would be replaced by the actual url used (which could dynamically be supplied via MP-config)

@fmhwong
Copy link
Contributor

fmhwong commented Mar 16, 2020

We didn't make the change as we cancelled 1.4. What is your use case?

@nastacio
Copy link

@pavolloffay

This has been delivered with @Traced(operationName = "somename")

@pavolloffay
Copy link
Contributor Author

@pilhuhn it could be implemented in SmallRye first.

E.g. @Traced(operationName = "getMyBla %u") where %u would be replaced by the actual url used (which could dynamically be supplied via MP-config)

This is an interesting request, although note that URL is present in the span tags. The span name should be a low cardinality - always the same value for the same operation.

@nastacio sorry I do not get your comment. What are you asking for?

@nastacio
Copy link

nastacio commented Mar 18, 2020

I am remarking that I think this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants