Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when error tag is used #10

Closed
pavolloffay opened this issue Nov 14, 2017 · 0 comments
Closed

Clarify when error tag is used #10

pavolloffay opened this issue Nov 14, 2017 · 0 comments
Milestone

Comments

@pavolloffay
Copy link
Contributor

pavolloffay commented Nov 14, 2017

The specification defines that Tags.ERROR should be used if there is any error. This definition is vague. Should it be added for response codes > 400 or when an exception is thrown which results in 500?

Instrumentations usually add error tag in exception states e.g. when the modeled operation failed or an exception is thrown.

true if and only if the application considers the operation represented by the Span to have failed

It is also a best practice to add the exception to logs see https://github.com/opentracing/specification/blob/master/semantic_conventions.md#captured-errors

@pavolloffay pavolloffay changed the title Clarify what error states are traced Clarify when error tag is used Nov 20, 2017
@pilhuhn pilhuhn added this to the 1.0 milestone Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants