Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Micrometers Metertag #612

Open
Lukas-Kaufmann opened this issue Sep 26, 2023 · 2 comments · Fixed by #753
Open

Add support for Micrometers Metertag #612

Lukas-Kaufmann opened this issue Sep 26, 2023 · 2 comments · Fixed by #753
Labels
type: enhancement New feature or request

Comments

@Lukas-Kaufmann
Copy link

Feature description

Micrometers annotation Metertag is intended to add tags to metrics based on a methods parameter.
It would be nice to have this feature supported.
@fivezeroes
Copy link

An alternative approach could be supporting the new expression syntax and using the extraTags field, I would be happy with either solution.

@hrothwell
Copy link
Contributor

An alternative approach could be supporting the new expression syntax and using the extraTags field, I would be happy with either solution.

FWIW that is not actually a viable option right now:

micronaut-projects/micronaut-core#10538

I am in the progress on working on something which may or may not support this, albeit not as nicely if I had to guess

@hrothwell hrothwell mentioned this issue May 4, 2024
Merged
@sdelamo sdelamo added the type: enhancement New feature or request label May 6, 2024
@sdelamo sdelamo linked a pull request May 13, 2024 that will close this issue
Build more tags using method context #753
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
No open projects
4.5.0 Release
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build more tags using method context hrothwell/micronaut-micrometer
4 participants
@sdelamo @fivezeroes @hrothwell @Lukas-Kaufmann