1525 move resource macro to core #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Oct 23, 2024
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/RawTestMacroSubstitution.java
Outdated
Show resolved
Hide resolved
AndreaLaGrotteria
force-pushed
the
1525-move-resource-macro-to-core
branch
from
68ba7fc
to
e72201d
Compare
|
@sdelamo I forced pushed to make the branch independent from the rawTest macro. The changes you suggested for rawTest are implemented in the corresponding PR |
sdelamo
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Multi-line strings need to be supported as an input to the macro.
This could be an input and it should work fine:
The `git.properties` file that is generated by the `gradle-git-properties` plugin
will not be accessible from the native executable unless access to the file is
configured in `resource-config.json`:
resource:META-INF/native-image/resource-config.json[]
AndreaLaGrotteria
force-pushed
the
1525-move-resource-macro-to-core
branch
from
0a6b4c1
to
9d500ea
Compare
|
Can you merge master into this PR |
sdelamo
requested changes
Oct 25, 2024
# Conflicts: # buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java # buildSrc/src/main/java/io/micronaut/guides/core/RawTestMacroSubstitution.java
sdelamo
requested changes
Oct 25, 2024
buildSrc/src/test/java/io/micronaut/guides/core/ResourceMacroSubstitutionTest.java
Outdated
Show resolved
Hide resolved
buildSrc/src/test/java/io/micronaut/guides/core/ResourceMacroSubstitutionTest.java
Outdated
Show resolved
Hide resolved
buildSrc/src/test/java/io/micronaut/guides/core/ResourceMacroSubstitutionTest.java
Outdated
Show resolved
Hide resolved
sdelamo
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.