Adds support for multi-line macro inputs. Makes MacroUtils more modular. Adds rawTest macro. Fix #1524. #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Oct 23, 2024
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/MacroUtils.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/io/micronaut/guides/core/RawTestMacroSubstitution.java
Outdated
Show resolved
Hide resolved
sdelamo
requested changes
Oct 24, 2024
buildSrc/src/test/java/io/micronaut/guides/core/RawTestMacroSubstitutionTest.java
Outdated
Show resolved
Hide resolved
AndreaLaGrotteria
changed the title
AndreaLaGrotteria
changed the title
sdelamo
approved these changes
Oct 25, 2024
buildSrc/src/main/java/io/micronaut/guides/core/RawTestMacroSubstitution.java
Outdated
Show resolved
Hide resolved
| @@ -18,7 +17,7 @@ class SourceMacroSubstitutionTest { | |||
|
|
|||
| @Test | |||
| void testSubstitute(){ | |||
| String str = "source:GithubConfiguration[]"; | |||
| String str = "source:GithubConfiguration[]\n"; | |||
There was a problem hiding this comment.
why do you need to add a \n line character.
Suggested change
| String str = "source:GithubConfiguration[]\n"; | |
| String str = "source:GithubConfiguration[]\n"; |
There was a problem hiding this comment.
this looks like a bad smell to me.
There was a problem hiding this comment.
If we have multi-line inputs, the different lines will be separated by a \n, so it was to test that. If you look at the other tests you will see that input without \n is also tested and works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.