Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL + Hibernate Guide don't depend on Micronaut Data Hibernate #1369

Closed
wants to merge 8 commits into from
Closed

SQL + Hibernate Guide don't depend on Micronaut Data Hibernate #1369

wants to merge 8 commits into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Nov 11, 2023

See: #1356

@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Nov 11, 2023
@sdelamo sdelamo changed the title remove yaml configuration from hibernate JPA guide SQL + Hibernate Guide don't depend on Micronaut Data Hibernate Nov 11, 2023
@sdelamo sdelamo linked an issue Nov 11, 2023 that may be closed by this pull request
Correction in the source guide for including micronaut-data-processor #1356
Open
@sdelamo sdelamo mentioned this pull request Nov 11, 2023
Merged
timyates
timyates approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sometimes wonder if we should just move micronaut-sql into micronaut-data as you can't seem to use one without the other 🤔

@sdelamo
Copy link
Contributor Author

sdelamo commented Nov 13, 2023

I sometimes wonder if we should just move micronaut-sql into micronaut-data as you can't seem to use one without the other 🤔

Yes, there is a weird cycle

I reported an issue:

micronaut-projects/micronaut-sql#1157

sdelamo and others added 3 commits November 17, 2023 08:54
@sdelamo
Update guides/micronaut-jpa-hibernate/micronaut-jpa-hibernate.adoc
4e1d6c1
@sdelamo
Update guides/micronaut-jpa-hibernate/micronaut-jpa-hibernate.adoc
9bb688e
@sdelamo @timyates
Update to 4.2.0 (#1370)
b0c18c0 
* 4.2.0-SNAPSHOT

* don’t specify all-open version

* oracle autonomous db

* Replace MySQL feature to use old dependency

Without this, the Maven/TestResources integration doesn't work as it's using an old version that doesn't know about connector-j

* Delete buildSrc/src/main/java/io/micronaut/guides/feature/FlywayReplacement.java

* Delete buildSrc/src/main/java/io/micronaut/guides/feature/database/MySQLReplacement.java

---------

Co-authored-by: Tim Yates <[email protected]>
@timyates
Copy link
Contributor

Something weird is going on here...

Adding

    annotationProcessor("io.micronaut.data:micronaut-data-document-processor")

fixes this...

I suspect micronaut-projects/micronaut-starter#2173 may be wrong 🤔

@sdelamo sdelamo assigned sdelamo and unassigned timyates Nov 26, 2023
@sdelamo
Copy link
Contributor Author

sdelamo commented Jan 19, 2024

Closed via #1421 and #1422

@sdelamo sdelamo closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

Assignees

@sdelamo sdelamo

Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.2.4 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correction in the source guide for including micronaut-data-processor
2 participants
@sdelamo @timyates