Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZXing.Net doesn't seem to be able scan more complicated PDF417 barcodes #557

Open
gtvracer opened this issue Mar 19, 2024 · 12 comments
Open

ZXing.Net doesn't seem to be able scan more complicated PDF417 barcodes #557

gtvracer opened this issue Mar 19, 2024 · 12 comments

Comments

@gtvracer
Copy link

Using ZXing.Net.Maui.Controls v0.4.0, which is based on ZXing.Net library, and the basic ZXing page and configuration, it can detect simple PDF417, but it fails to detect more complex ones, like the one on the back of a California drivers license. It also doesn't keep the torch on either, but flashes once when the page initializes. I've tried the barcode images samples on the internet by searching for "PDF417 images", only the simple ones are read....

I've tried two other packages, both based on ZXing.Net, BarcodeScanning.Native.Maui and Camera.MAUI/Camera.MAUI.ZXing. Neither works either for complex PDF417.

The Xamarin version of ZXing is able to read the CA drivers license barcode, fyi..

I'm using Visual Studio v17.9.2, XCode 15.3 and .net8.

Any insight will be appreciated.
This PDF417 scanning is for an app the County of Santa Cruz, CA is creating for our local law enforcement, so any help will be appreciated!!

Thanks!

Page:

<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             xmlns:zxing="clr-namespace:ZXing.Net.Maui.Controls;assembly=ZXing.Net.MAUI.Controls"
             x:Class="MyProject.Views.ScanPage"
             Title="ScanPage">   
        <zxing:CameraBarcodeReaderView
			x:Name="barcodeView"
                        IsTorchOn="True"
			BarcodesDetected="BarcodesDetected" />        
</ContentPage>

Code behind:

public partial class ScanPage : ContentPage
{
	public ScanPage()
	{
		InitializeComponent();
        BindingContext = this;

        barcodeView.Options = new ZXing.Net.Maui.BarcodeReaderOptions()
        {
            TryHarder = true,
            AutoRotate = true,
            Multiple = true,
            Formats = BarcodeFormats.TwoDimensional // | ZXing.Net.Maui.BarcodeFormat.QrCode | BarcodeFormat.Pdf417 
        };
        barcodeView.IsTorchOn = true;
	}

    protected void BarcodesDetected(object sender, BarcodeDetectionEventArgs e)
    {
        foreach (var barcode in e.Results)
        { // dumps to Debug.WriteLine()...
            App.Log($"Barcode: {barcode.Format} -> {barcode.Value}");
        }

        var first = e.Results?.FirstOrDefault();
        if (first != null)
        {
            Dispatcher.DispatchAsync(async () =>
            {
                await DisplayAlert("Barcode detected", first.Value, "OK");
            });
        }
    }
}

MauiProgram.cs:

public static class MauiProgram
  {
      public static MauiApp CreateMauiApp()
      {
          var builder = MauiApp.CreateBuilder();
          builder
              .UseMauiApp<App>()
              .UseMauiCommunityToolkit()
              .UseBarcodeReader()
              .ConfigureFonts(fonts =>
              {
                  fonts.AddFont("OpenSans-Regular.ttf", "OpenSansRegular");
                  fonts.AddFont("OpenSans-Semibold.ttf", "OpenSansSemibold");
              })
              .ConfigureMauiHandlers(handlers =>
              {
                  handlers.AddHandler(typeof(PillCheckbox), typeof(PillCheckboxRenderer));
              });

          builder.Services.AddSingleton<IImageInfo, ImageInfo>();

#if DEBUG
          builder.Logging.AddDebug();
#endif

          var app = builder.Build();

          //ServiceProviderHelper.Initialize(app.Services);
          return app;
      }
  }
@axxel
Copy link

axxel commented Apr 7, 2024

Can you give an example of what you consider to be a "complex" PDF417 symbol and therefore fails to be decoded with ZXing.NET?

@gtvracer
Copy link
Author

gtvracer commented Apr 7, 2024 via email

@axxel
Copy link

axxel commented Apr 7, 2024

Hi Tom, no, I'm not Mike, I'm the maintainer of the zxing-cpp project. I re-implemented a bunch of the detector algorithms but the PDF417 detector is still mostly the one from the original Java ZXing library. I assume ZXing.NET's version is also a 1 to 1 port from the Java code. So all three should behave the same, which is contradicted by your your observation that the Xamarin version of ZXing is working. So I was curious what zxing-cpp does with your specific sample.

@gtvracer
Copy link
Author

gtvracer commented Apr 7, 2024 via email

@gtvracer
Copy link
Author

gtvracer commented Apr 7, 2024 via email

@gtvracer
Copy link
Author

gtvracer commented Apr 8, 2024 via email

@gtvracer
Copy link
Author

gtvracer commented Apr 8, 2024

Here is a link to the image: https://www.bing.com/images/search?view=detailV2&ccid=Ss6OGv4g&id=E6A2E8947ADD25E7314DD826338FFE6EF9CA9A65&thid=OIP.Ss6OGv4g3YJACytkgc4l-AHaEX&mediaurl=https%3a%2f%2fidtempl.com%2fwp-content%2fuploads%2f2022%2f04%2fScreenshot-2022-06-04-135541.jpg&cdnurl=https%3a%2f%2fth.bing.com%2fth%2fid%2fR.4ace8e1afe20dd82400b2b6481ce25f8%3frik%3dZZrK%252bW7%252bjzMm2A%26pid%3dImgRaw%26r%3d0&exph=730&expw=1236&q=driver+license+pdf417+images&simid=608009873378706014&FORM=IRPRST&ck=265CE94CD1C8581457D5EBA75B6B4D6F&selectedIndex=0&itb=0&ajaxhist=0&ajaxserp=0

@axxel
Copy link

axxel commented Apr 8, 2024

Maybe there is something wrong with the bing search link you provided. I get this image if I follow that link. My zxing-bench tool that compares the ZXing.NET implementation with the .NET wrapper of zxing-cpp shows that both detect two barcodes in that image, a Code128 and a PDF417 one. So both work just fine with this image (although my implementation is 30x faster ;)).

@gtvracer
Copy link
Author

gtvracer commented Apr 8, 2024 via email

@gtvracer
Copy link
Author

gtvracer commented Apr 8, 2024 via email

@axxel
Copy link

axxel commented Apr 8, 2024 •
edited
Loading

I have no experience with zxing.net.maui. I was referring to https://www.nuget.org/packages/ZXing.Net and my benchmark tool is currently using 0.16.14.

CORRECTION: I'm using https://www.nuget.org/packages/ZXing.Net.Bindings.SkiaSharp/ version 0.16.14 and that is depending on https://www.nuget.org/packages/ZXing.Net version 0.16.9.

@gtvracer
Copy link
Author

gtvracer commented Apr 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axxel @gtvracer