add -remove command #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
morgaesis
requested changes
Jan 10, 2022
| @@ -91,7 +91,7 @@ class MusicBot: | |||
|
|
|||
| COMMAND_PREFIX = "-" | |||
| REACTION_EMOJI = "👍" | |||
| DOCS_URL = "github.com/michael-je/the-lone-dancer" | |||
| DOCS_URL = "www.github.com/michael-je/the-lone-dancer" | |||
There was a problem hiding this comment.
Why is this necessary? In order to get a clickable link this needs to start with https:// and can't be in a formatted code block. Making the doc url a hyperlink also causes url preview below the message, which I'm not a fan of.
There was a problem hiding this comment.
It's not necessary, I just don't think that the original properly signals that it's a link. But github actually doesn't use the www. prefix, so https:// is probably more appropriate.
Links inside code blocks don't become hyperlinked.
|
I'll also add some tests! It's about time I get my hands dirty with mocking 😨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
-removecommand, which allows for removing specific songs from the queue.Also:
www.to the docs url-helpcommand slightly by adding an extra whitespace between the command names and their descriptions. I Did this because one of the command names was touching its description, which was quite ugly.Closes #68