Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

satellite command #107

Open
2 tasks
0x5c opened this issue Dec 11, 2019 · 11 comments
Open
2 tasks

satellite command #107

0x5c opened this issue Dec 11, 2019 · 11 comments
Assignees
Labels
bug Something isn't working frozen long-term blocked investigate This issue needs investigation mitigated A better fix is needed priority-low This issue can be worked on later

Comments

@0x5c
Copy link
Member

0x5c commented Dec 11, 2019

  • Sanitise that sat name

Satellites must match the satellite name from nasabare.txt e.g. AO-91 or ISS

  • Filter for valid grids

Locations can be 4-12 character maidenhead grid squares

@0x5c 0x5c added the bug Something isn't working label Dec 11, 2019
@0x5c 0x5c added this to the v2.1.0 milestone Dec 11, 2019
@0x5c 0x5c added the priority-low This issue can be worked on later label Dec 11, 2019
@0x5c 0x5c modified the milestone: v2.1.0 Dec 11, 2019
@classabbyamp classabbyamp removed the priority-low This issue can be worked on later label Dec 11, 2019
@classabbyamp classabbyamp self-assigned this Dec 23, 2019
@classabbyamp
Copy link
Member

classabbyamp commented Dec 23, 2019

Set the request type to application/json or set ?json=true to get json results instead of rendered pages or images.

We should be able to construct embeds for this

example: https://www.satmatch.com/satellite/FO-29/obs1/CN87UO/obs2/EN61ev40?duration_hrs=72&json=true

@classabbyamp classabbyamp removed this from the v2.1.0 milestone Dec 24, 2019
@classabbyamp
Copy link
Member

is being bumped to a later version

Notes:

  • how to download nasabase.txt?
  • add argument for number of hours
  • ask K5EM about adding peak angle of pass to JSON API
  • possible embed layout (maybe remove end, only show start, duration, and peak):
    image

@0x5c 0x5c added priority-low This issue can be worked on later mitigated A better fix is needed labels Dec 25, 2019
@classabbyamp
Copy link
Member

in progress work on this command is in the branch sat-cmd

@0x5c 0x5c added the blocked Blocked by something else label Jan 3, 2020
@0x5c 0x5c added the investigate This issue needs investigation label Oct 30, 2020
@0x5c
Copy link
Member Author

0x5c commented Oct 30, 2020

It would be somewhat easy to filter and match names from the provided nasabare.txt list. Worse part is parsing the file.

@classabbyamp
Copy link
Member

at this point, I think it would be better to switch to using n2yo as our data source.

@0x5c
Copy link
Member Author

0x5c commented Mar 22, 2021

So a full rewrite?
Does ny2o support all the feature we used, and will it require gridtools?

@classabbyamp
Copy link
Member

ya pretty much a full rewrite. not like there was much useful code there anyways, with how old it is. n2yo should be able to show things like max elevation and pass lengths. gridtools possibly required, but it's a super-simple integration, especially whe it's already used in the bot

@0x5c
Copy link
Member Author

0x5c commented Mar 23, 2021

I don't really remember the original sat command, is there any info it had that ny2o does not?
As for gridtools, would allow for accepting both squares and lat/long, and even do conversion if wrapped in a converter

@classabbyamp
Copy link
Member

I think n2yo has a superset of info VS sat match. good idea on the gridtools

@0x5c
Copy link
Member Author

0x5c commented Mar 24, 2021

Let's switch then
New issue to start fresh?

@classabbyamp
Copy link
Member

big issue with N2YO: only 1 observer for passes. we should bug the satmatch author again instead.

@classabbyamp classabbyamp added frozen long-term blocked and removed blocked Blocked by something else labels Mar 25, 2021
@classabbyamp classabbyamp changed the title Fix the sat command implementation satellite command Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frozen long-term blocked investigate This issue needs investigation mitigated A better fix is needed priority-low This issue can be worked on later
Projects
None yet
Development

No branches or pull requests

2 participants