Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Base Module definitions #28

Open
leoglonz opened this issue Dec 8, 2024 · 0 comments
Open

Expand Base Module definitions #28

leoglonz opened this issue Dec 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@leoglonz
Copy link
Collaborator

leoglonz commented Dec 8, 2024

Summary

  • Currently, the base classes for trainers, loss functions, data loaders, and data samplers are very basic implementations on top of Torch. These should be expanded and refined to reflect and enforce the minimum standards we have on class methods, inputs and outputs.

Actions

  • Bring requirements of modules into alignment with the rules and expectations enforced by base classes.

Considerations

  • Now that we are moving forward with full development, we should focus on small but critical minutia like this.
@leoglonz leoglonz added the enhancement New feature or request label Dec 8, 2024
@leoglonz leoglonz self-assigned this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant