Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Prime factorization in the error message #556

Closed
MrVeka opened this issue Jul 5, 2024 · 2 comments · Fixed by #557
Closed

[bug] Prime factorization in the error message #556

MrVeka opened this issue Jul 5, 2024 · 2 comments · Fixed by #557

Comments

@MrVeka
Copy link
Contributor

MrVeka commented Jul 5, 2024 •
edited
Loading

Hi, when trying to create a Galois field of 50 we get this error message :
Argument 'order' must be a prime power, not 50 = 2**1 + 5**2.

I think it should have been 2**1 * 5**2 or 2^1 * 5^2, I'ill try to implement the latter if it's ok.
@MrVeka MrVeka changed the title Prifactorisation mistake in the error message Prime factorization in the error message Jul 5, 2024
@MrVeka MrVeka changed the title Prime factorization in the error message [bug] Prime factorization in the error message Jul 5, 2024
@mhostetter
Copy link
Owner

Thanks for the report and PR!

@mhostetter mhostetter linked a pull request Jul 5, 2024 that will close this issue
Fixes bug in the error message for none prime power order (Issue #556) #557
Merged
@mhostetter
Copy link
Owner

Released in v0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes bug in the error message for none prime power order (Issue #556) MrVeka/galois
2 participants
@mhostetter @MrVeka