Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated features? #3

Open
xitefanjisi opened this issue Apr 15, 2020 · 3 comments
Open

Repeated features? #3

xitefanjisi opened this issue Apr 15, 2020 · 3 comments

Comments

@xitefanjisi
Copy link

xitefanjisi commented Apr 15, 2020

Thank you for your great feature selection method. However, I found that your method might lead to such a situation that the same features could be selected for multiple times. For example, after training, the method get_support() might output a result like [3, 4, 6, 2, 2, 5, 1, 0]. In this case, the second feature has been selected twice. Is it possible to avoid such cases using concrete autoencoders? Thank you!

@a8-mlevy
Copy link

I am noticing the same thing

@Alexanderbertrand
Copy link

We had a similar problem when using this method for selection of EEG channels. We were able to reduce the number of duplicate selections by adding a regularization term to the loss, which penalizes such duplicates.
Paper here: https://homes.esat.kuleuven.be/~abertran/reports/TS_JNE_2021.pdf
Github: https://github.com/AlexanderBertrandLab/Gumbel-Channel-Selection

@mfbalin
Copy link
Owner

mfbalin commented May 24, 2022

In my experience, replicated features are caused by not having enough number of epochs to converge. When I was running experiments for the ICML paper, when I set the hyperparameters right, I never observed replicated features selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants