-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more calculation methods #66
Comments
Hi
Can you provide link to the official page of these methods ? so I can take their exact parameters ?
Some android manufactures already have this feature built-in to the OS |
I will see how or where to get these links or parameters....
Yes I just found out that Google play has nearby share but they collect data that is not good for privacy, plus Google play nearby share doesn't share apps from F-droid, I only found the apps that I downloaded from google play. There is also nearby share in the phone settings that also collects data plus it may not work for all regions I think it is better to make and put a nearby share feature into your app :) (just for sharing your app offline) just like F-droid did, you can have a look at their source code and see how they did it in case you need to.... it would be really good idea.
You mean APK? I meant sharing the app itself in case the sender doesn't have the APK file |
yeah I meant APK I prefer to let third party apps handle it. I'm pretty sure there's a lot of apps you can use to get the APK file. check this app for example, I just found it: https://f-droid.org/en/packages/be.brunoparmentier.apkshare/ |
OK :)
Very good app thank you very much :) |
Hi @meypod Many Twelver Muslims in various countries of the world, as well as many applications, rely on (Astronomical Research Center) to know the prayer times I wonder, can you add this method of calculation to this great application? |
Hi @AI-IMED , have you tried the "Shia Ithna Ashari, Leva Institute, Qum" or "Shia, Institute of Geophysics, University of Tehran" method to see how it compares ? |
It saddened me , I depend on it because it gives very accurate prayer times.
Yes, I tested that, it is not accurate, I have to adjust the prayer times, but even with adjusting the times, after two months or more, it makes a difference in the prayer times again |
I'm sorry but without knowing the exact details of their calculation there's not much I can do
Make sure to try changing the advanced settings in the calculation settings, if the calculated time is close, one of those may help adjust your time correctly |
I forgot to mention, It is necessary to add midnight to the calculation adjustment options, because there is a difference of opinion among the jurists of the Twelver doctrine, some of whom believe that the time of midnight is between sunset and dawn, and some of them believe that it is between sunset and sunrise |
I use https://github.com/batoulapps/adhan-js library, I wanted to add adjustments for the midnight time, but it is provided by the library, and it doesn't provide a way to adjust it please create an issue there, if it gets added there, I can add it as well |
"Shia, Institute of Geophysics, University of Tehran" method seems to match the times provided by the website you mentioned with only around 1 minute of difference which is usually due to rounding |
Yes, indeed, the difference is 1 minute, this calculation method seems better. |
Hi @meypod I got these links by myself, some by searching in Google and some from Wikipedia https://www.londonprayertimes.com/ https://www.e-solat.gov.my/ https://www.grandemosqueedeparis.fr/horaire-des-prieres-paris Now these 3 websites below are in Arabic if you don't understand arabic, please tell me and I will help you in-shaa-Allah http://www.affaires-religieuses.tn/public/ar https://www.marw.dz/%D9%85%D9%82%D8%A7%D9%84%D8%A7%D8%AA-%D9%88%D8%AF%D8%B1%D8%A7%D8%B3%D8%A7%D8%AA/%D9%85%D9%88%D8%A7%D9%82%D9%8A%D8%AA-%D8%A7%D9%84%D8%B5%D9%84%D8%A7%D8%A9 https://www.habous.gov.ma/prieres/index.php Or you can have a look at the source code of the app which I got calculation methods names from and search for links and parameters used in it |
Well that would make it a lot easier, they got all the parameters it seems for example https://www.londonprayertimes.com/ takes time from https://www.eastlondonmosque.org.uk/prayer-times-and-calendar-explained which are based on time from http://astro.ukho.gov.uk/psp/index_beta.html which I can't find the calculation parameters from |
You mean comparing times in the app I mentioned with those in the links? No, I haven't. OK I will do it. |
Also Speaking of calculations, can you also make the app to do online calculation and not only offline calculation if possible? |
Ah yes I forgot...I will have to change phone timezone for that.. Do you want me to compare times in the links with those in Google search? Or what? :) |
Not really, I try to keep app offline as much as possible (making things online make app more complex and prone to errors) compare times with the official links with the times of the same method in five prayers app |
At least not that kind of errors that may affect app installation am I right? Or you mean errors that may affect offline mode and everything in the app? I agree with you to make most of the app in offline mode I mean it seems that your idea is to make a small sized offline adhan app .. right? If you think online mode will increase the app's size then how about you clone this app and that new clone should have extra features like online mode ? I mean at the end you should have 2 apps one small sized and offline and one with extra features and it may become big in size and you can name it for example "Al-Azan-Extra features"
As you command :) |
sorry, I didn't mean it like that
online, means it requires a network connection, and a backend though one of the reasons is that in future if I manage to do something about Qibla map feature, I may remove internet permission from app to make it completely offline, which is better for privacy There are other apps with mosques time like https://github.com/mawaqit/android-tv-app , And online apps like https://github.com/metinkale38/prayer-times-android |
No brother :) .. when I said that, I meant like "I will do it with pleasure" ..
Aha I see now the big picture. Thanks for clarifying.
Hmm..indeed..yes
Thank you for your great suggestions. |
The feature of entering custom angles looks interesting, I'm eagerly awaiting the feature to try it, because I do not know my angle accurately, and to see if it will contribute to adjusting the accuracy of the calculations that I need. |
methods other than Algeria and Unified London don't match exactly with their official websites when checked inside the five prayers app |
I was planning to do it for you soon but it is just I am busy these days ... militry-related things and others... |
And what is the solution now? Also the app you mentioned https://github.com/metinkale38/prayer-times-android has other calculation methods like |
Will add Algeria method as that's the only matching one Unified London is for East London mosque and they use moonsighting committee method adjusted to their location so probably not going to add that |
That is great news. Good luck with the rest of the countries. |
Muslim Pro also has other calculation methods https://www.muslimpro.com/Prayer-times-Germany-DE# -Federation of Islamic Associations in Basque Country And this one below has some angles for some calculation methods like Fixed Isha and EgyptBis ### but be careful when using Muslim Pro, it is accused of selling users data to US militry Also I found this I don't know how to explain it but it seems it has lots of functions so I will just leave it here in case you find it useful https://pkg.go.dev/github.com/RadhiFadlillah/go-prayer |
Hi Here are some official links UAE General Authority of Islamic Affairs And Endowments Islamic Centre Aachen Federation of Islamic Associations of New Zealand Religious administration of Muslims of ukraine Kementrian Hal Ehwal Ugama (Brunei Darussalam) Union de comunidades Islamicas de Valencia Islamske zajednice u Bosni i Hercegovini. Islamske skupnostti v Republiki sloveniji (Slovenia) These 3 below I can't find prayer times on their websites, but I may send them emails and see if I can get prayer times Muslim league in poland All Ceylon Jamiyyathul Ulama (sri lanka) central islamic council of thailand |
Here is official response from https://acju.lk/en regarding prayer timetable for sri lanka And here is Prayer Timetable with Angles in the PDF file that they sent |
Here is official response from Union of Islamic Communities of Spain https://ucide.org/ regarding prayer times for Spain cities And this is their message so it can be translated
And here is the website that they mentioned in the message http://www.hispanomuslim.es/panya/azala.htm it has Prayer Times for Spainian cities with coordinates and also has other things. I asked them for English version for the website but they said only Spanish version is available
|
Thanks for the effort |
You mean these websites can't be useful at all in knowing the angles? I asked them all like that "do you have an islamic prayer timetable for all of [Country] cities for every year or month please? Or do you have your own calculation method for prayer times?" Do you want me to ask them like that? |
yeah I think something like this: "What methods and parameters do you use to calculate the prayer times ? for example some apps that calculate adhan offline use Fajr, Isha and Maghrib angles. Can you provide the numbers or formulas that you use or a link to the official documents that explains what you use ?" |
Thanks for adding Algeria and Brunei methods I sent your question and I am waiting for their reply. If you select city, you can see the mentioned method above Should that be useful? |
Also please don't forget to add Bosnia and Herzegovina method...I don't think it will be difficult for you to find their parameters..they have source code on github EDIT: I have my doubts regarding their prayer times it seems different from prayer times of other websites like |
Bosnia source code didn't include parameters required for calculating, it only has times also, the official websites are the source of truth for their times, if other apps are different from them, then the apps are incorrect |
You mean governments websites and their ministries?
The reason I had my doubts is that the 2 websites I mentioned have almost same prayer times and they are different from vaktija.ba prayer times. Regarding http://www.hispanomuslim.es/panya/azala.htm |
http://www.hispanomuslim.es/panya/cmce.htm This link has lots of Islamic Communities from other countries. |
Here is official response from Union of Islamic Communities of Spain https://ucide.org/ regarding angles and methods for Spain
### Translation: |
The website you contacted (ucide.org) does not seem to be related to the website you mentioned (hispanomuslim.es) if they are related, you should have asked for method that is used to generate times on hispanomuslim.es, not in general. wherever there's a time table, there's a method used to calculate it. we need the details of the method used to calculate it. anything else is not needed. |
I sent them a message yesterday at least regarding angles for each region that is part of UCIDE like Valencia city and basque country. UCIDE consists of several regions so I asked for their angles and now I am waiting for their reply. By the way I Also sent a message to https://www.qafqazislam.com/index.php?lang=en§ionid=123 they are Azerbaijanis and have prayer times for Azerbaijani cities ...they should provide us with angles or calculation method. https://www.koreaislam.org/en/prayer-times/ |
This was my message to ucide.org
And Here is official response from them
They probably use Muslim World League method. I am not sure. As for Islamophobia link, I didn't request that. |
I use adhan js which does all the mathmatics. I can't touch the internal calculations myself with my limited knowledge I guess no need to add it if it's same as Muslim world league |
You mean you can't calculate to get the angles by yourself due to your limited knowledge?
I at least may look for how to contact Valencia and basque country to get their angles and I have 2 reasons for that: -Some apps use angles for basque country like "muslim pro" and "prayer times - Mosque finder" But I don't know if the angles are reliable or not |
Regarding Morocco calculation method, here is an open source project that focuses on prayer times in cities of Morocoo, I think it is in JavaScript , also it is based on prayer times from Ministry of religious Endowments and Islamic Affairs of Morocoo ### Edit: They don't have parameters |
I got angles for Morocco which I don't know if they are reliable or not While somebody else mentions on their forums that those are the right angles Fajr: 19,1 Isha: 17 Edit: I just realized that he mentioned right angle for Casablanca city in Morocco and not for all cities. |
Thanks for the time you have put into this @TorCzaf |
You are most welcome
Take your time. Brother. |
https://github.com/kafiln/salati/ does not calculate times itself |
oh i see you have asked and the owner already has said in the response so yeah, I can't find anything on morocco either |
@meypod Also in https://www.islamicfinder.org it is 18,18 However there are 3 pages that say it is 20,18 Also please add these French Angles that I see in some apps "France 15" and "France 18" for those who live in France and Don't know (haven't discovered) these angles, I mean if "Union Organization Islamic de France" (Angle 12) is not an appropriate method in some French regions people should switch to "France 15" or "France 18" and see whether or not they are appropriate. Same thing in Egypt, some people don't know that there is another Egyptian calculation method "Egypt Bis"...please add it too. Also I sent a message to "Salatuk" team regarding the angles they have for each calculation method they use in their app. |
For Malaysiya neither 18,18 nor 20,18 matches with https://www.e-solat.gov.my/index.php But 20,18 is a little closer For Egypt 19.5,17.5 matches with Al-Azhar mosque time https://mawaqit.net/en/masjid-alazhar-le-caire-4293024-egypt , But 20,18 got like 2 minute difference, is there any official link for 20,18 angles? France 18 and 15 seems more closer to Grand mosque of Paris prayer times but still doesn't match exactly, so will add France 18 and 15 |
Unfortunately I couldn't find anything about "EgyptBis"...Not even the meaning of "Bis". |
Hi , can you please add more calculation methods like:
-Ministry of religious affairs - Tunisia
-Ministry of Islamic affairs - Morocco
-Ministry of religious affairs and wakfs - Algeria
-London unified prayer times
-Jabatan kemajuan Islam - Malaysia
-Mosquee de Paris - France
-Angle 18° France
-Angle 15° France
And maybe there is more.
====
And also it would be good to add a button to share the app via Bluetooth in case if the sender and the receiver both have no WiFi/internet.
I took this idea from F-droid store itself.
This could be useful for people who travel in desert or in unknown places or be in unpopular areas...ETC
The text was updated successfully, but these errors were encountered: