Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to fix umi-bundle-defaults on Vite #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinrodriguez-io
Copy link

@kevinrodriguez-io kevinrodriguez-io commented Sep 13, 2024

Attempts to address:

#146
#147
#124

How to Reproduce

  1. Create a Vite React App:

    • Use the following command to create a new Vite React app:
      npm create vite@latest my-react-app --template react
    • Navigate to the project directory:
      cd my-react-app
    • Install dependencies:
      npm install
  2. Add Umi and Solana Wallet Adapter:

    • Install Umi and Solana wallet adapter packages:
      npm install @metaplex-foundation/umi @solana/wallet-adapter-react ...other wallet adapter deps
    • Install Umi bundle defaults:
      npm install @metaplex-foundation/umi-bundle-defaults
  3. Configure Umi and Solana Wallet:

    • Follow the Umi documentation to set up Umi and the Solana wallet adapter in your project. This typically involves:
      • Setting up the Umi provider.
      • Configuring the Solana wallet adapter.
      • Adding necessary imports and configuration code to adapt the wallet adapter for umi.
  4. Run the Application:

    • Start the Vite development server:
      npm run dev
    • Observe the application behavior. Issues should be apparent at this stage if you at least are instantiating the UMI wallet adapter and UMI overall (You won't get the error just by installing it, but on usage).
  5. Expected Outcome:

    • The application should integrate Umi and Solana wallet adapter correctly.
    • Any errors or issues should be logged in the console for further debugging.

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 321c902

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umi-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 9:24pm

@MarkSackerberg
Copy link
Contributor

Thank you very much!
Do you maybe have a MVP repo where this is working?

@kevinrodriguez-io
Copy link
Author

I don't, I ended up fixing this via polyfills on Vite.

It would be helpful to get some guidance on how to run this whole repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants