Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the description. #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

luke-jarymowycz
Copy link
Contributor

No description provided.

psteinbachs
psteinbachs previously approved these changes Mar 17, 2023
Copy link

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@luke-jarymowycz
Copy link
Contributor Author

fixing code signing

@luke-jarymowycz luke-jarymowycz deleted the update_description branch March 17, 2023 20:49
@luke-jarymowycz luke-jarymowycz restored the update_description branch March 17, 2023 20:49
@JAORMX
Copy link
Collaborator

JAORMX commented Mar 17, 2023

@luke-jarymowycz code signing uses sigstore's gitsign. But it's non-blocking. You can still merge code even if that job is failing. I can help you get set up on Monday

@luke-jarymowycz luke-jarymowycz force-pushed the update_description branch 2 times, most recently from 3a9d3a3 to ffd7cc8 Compare March 17, 2023 20:55
@luke-jarymowycz
Copy link
Contributor Author

@luke-jarymowycz code signing uses sigstore's gitsign. But it's non-blocking. You can still merge code even if that job is failing. I can help you get set up on Monday

Thanks... just one of those things I was now trying to unwind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants