Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): wrong variable names on rpm install #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scripts): wrong variable names on rpm install #201

wants to merge 1 commit into from

Conversation

h-banii
Copy link

@h-banii h-banii commented Feb 1, 2024

Fixes #181

Some variable names in the install_rpm() function were wrong.

This causes download() to get called with its first argument empty, which in turn causes the curl -sfLo issue mentioned.

@h-banii
Copy link
Author

h-banii commented Feb 1, 2024

before

image

after

image

belligerentcrow
belligerentcrow approved these changes Feb 25, 2024
View reviewed changes
Copy link

@belligerentcrow belligerentcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had the same issue. it worked after applying these changes. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belligerentcrow belligerentcrow belligerentcrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

curl: option -sfLo: is badly used here
2 participants
@h-banii @belligerentcrow