-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with inserting online resource format #314
Comments
@CarHenkel Can you test your environment with using values like With the change reverted, the validation should fail on that item. |
It seems like there are 2 options. Not sure what the best approach is for this? |
Hi @ianwallen In ECCC environment: |
@bo-lu can you check if the code is being stored by FGP (discussion here indicates that storing the multi-lingual label would be appropriate) |
There is a bug when attempting to add an online resource format such as ASCII (CDED)
When validating, it produces the following error.
The reason, we get this error is because the data is store as
The validation is validating based on the real code which is CDED ASCII and it identifies that it is not the same as ASCII (CDED) and fails.
There was an attempt to fix this but with PR #259. However this PR was checking against the English code/French Code - when it should be checking the main code.
The problem is that the main code is not in the data
1 - Is there a bug in saving the data - i.e should it have the main code stored instead of translated values? This does not seem correct as it would be difficult to program to check all codes.
2 - Should the validation accept Eng code, Fra codes, and main codes in the check?
The text was updated successfully, but these errors were encountered: